Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everest mount write docs #8725

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Everest mount write docs #8725

wants to merge 7 commits into from

Conversation

idanovo
Copy link
Contributor

@idanovo idanovo commented Feb 26, 2025

No description provided.

@idanovo idanovo added docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Feb 26, 2025
@idanovo idanovo self-assigned this Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

🎊 PR Preview a2557e8 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8725.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

Copy link

E2E Test Results - Quickstart

11 passed

@idanovo idanovo marked this pull request as ready for review February 26, 2025 13:16
@@ -0,0 +1,26 @@
---
title: Mount Write Mode Limitations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Mount Write Mode Limitations
title: Mount (Everest) file system behavior

@@ -0,0 +1,26 @@
---
title: Mount Write Mode Limitations
description: Limitations of the mount write mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File system semantics limitations and and general info

Comment on lines 24 to 27
****
Everest mount write mode is now available for MacOS on experimental mode!
[Everest mount write mode limitations](mount-write-mode-limitations.md).
{: .note }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this under ### Write Mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not agree!

  1. It should be at the beginning of the page so users will be aware of the fact that write-mode is available now.
  2. I think we agreed we won't have a "write-mode" section.

@@ -21,13 +21,18 @@ This functionality is currently in limited support and is a Read-Only file syste
⚠️ No installation is required. Please [contact us](http://info.lakefs.io/thanks-lakefs-mounts) to get access to the Everest binary.
{: .note }

****
Everest mount write mode is now available for MacOS on experimental mode!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Everest mount write mode is now available for MacOS on experimental mode!
Everest mount supports writing to the file system and now available for NFS (the default protocol for MacOS)!

@@ -179,8 +230,40 @@ The minimal RBAC permissions required for mounting a prefix from a lakeFS reposi
"action": [
"fs:ListObjects",
"fs:ReadCommit",
"fs:ReadBranch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        {
        	"action": ["fs:ReadConfig"],
        	"effect": "allow",
        	"resource": "*"
        }

## Everest Partial-Read Mode
- Mount write mode is not supported with Everest partial-read mode.

## Functionality Limitations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very generic title.
We can generalize this and talk about "consistency and data sync"
talk about behavior of sync, diff, commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • sync is an internal term
  • I don't see how this limitation belongs in "consistency and data sync"

## Functionality Limitations
- Newly created empty directories will not reflect as directory marker in lakeFS.

## File System Limitations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see maybe i missed - POSIX permissions are not supported and we set default permissions given to files and dirs.

## Functionality Limitations
- Newly created empty directories will not reflect as directory marker in lakeFS.

## File System Limitations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see in this design section
Split the limitations to not-supported, partially supported and behavior modified.
Then explain the things there.

parent: Mount
---

# Mount Write Mode Limitations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Mount Write Mode Limitations
# Mount Write Mode file system behavior

---

# Mount Write Mode Limitations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to make it more structured because there are many things to unpack here.

  1. Overview
  2. Architecture and concurrency model - few bullets not long are enough but that section
    is great!
  3. Committing Changes
  • how it works, consistency, merge strategy, what happens after commit.
  • writes during commit may be lost, dont do it
  1. Limitations
  • sub section: functional bullets: (NFS, no eviction for write dir its not cache, durability: restarting the mount may lead to unpredicted behavior)
  • sub section: FS Limitations (as mentioned below)

@idanovo idanovo requested a review from Isan-Rivkin February 26, 2025 16:37
@idanovo idanovo requested a review from ozkatz February 26, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants