Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/graveler storage id enrichment #8729

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Task/graveler storage id enrichment #8729

wants to merge 3 commits into from
+159 −38

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Feb 26, 2025

No description provided.

@guy-har guy-har requested review from nopcoder and N-o-Z February 26, 2025 13:57
@guy-har guy-har added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Feb 26, 2025
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

@guy-har guy-har force-pushed the task/graveler-storage-id-enrichment branch 2 times, most recently from fb4a734 to 364c903 Compare February 26, 2025 15:28
@guy-har guy-har force-pushed the task/graveler-storage-id-enrichment branch from 364c903 to 863dc4c Compare February 26, 2025 15:29
N-o-Z
N-o-Z approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One suggestion

pkg/api/controller.go Outdated
@@ -2024,7 +2024,7 @@ func (c *Controller) CreateRepository(w http.ResponseWriter, r *http.Request, bo
}

// Validate storage ID exists
storageID = c.getActualStorageID(storageID)
storageID = config.GetActualStorageID(c.Config.StorageConfig(), storageID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion - move this to line 1986 (or even replace that line)

nopcoder
nopcoder approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but look into GetStorageByID and just return the single storage and fill back the ID in the case we read the information from the KV. It will allow GetStorageByID to align the value of the storage in case it is different from the one we stored.

pkg/graveler/ref/repository_iterator_test.go Outdated
@@ -2,6 +2,7 @@ package ref_test

import (
"context"
"github.com/treeverse/lakefs/pkg/config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goimports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guy-har @nopcoder @N-o-Z