Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Esti Improvements #8731

Merged
merged 2 commits into from
Feb 26, 2025
Merged

More Esti Improvements #8731

merged 2 commits into from
Feb 26, 2025

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Feb 26, 2025

Support optional client param for upload
Externalize more functions

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached msb labels Feb 26, 2025
@N-o-Z N-o-Z requested a review from guy-har February 26, 2025 19:50
@N-o-Z N-o-Z self-assigned this Feb 26, 2025
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -339,7 +341,7 @@ func createRepository(ctx context.Context, t testing.TB, name string, repoStorag
"create repository '%s', storage '%s'", name, repoStorage)
}

func deleteRepositoryIfAskedTo(ctx context.Context, repositoryName string) {
func DeleteRepositoryIfAskedTo(ctx context.Context, repositoryName string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link

E2E Test Results - Quickstart

11 passed

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

@N-o-Z N-o-Z merged commit 627a82b into master Feb 26, 2025
39 of 41 checks passed
@N-o-Z N-o-Z deleted the task/more-esti-improvements branch February 26, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached msb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants