[pre-commit.ci] pre-commit autoupdate (#430)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Saugat Pachhai (सौगात) <[email protected]>

Author: pre-commit-ci[bot]

.pre-commit-config.yaml

@@ -20,7 +20,7 @@ repos:
       - id: sort-simple-yaml
       - id: trailing-whitespace
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: 'v0.12.4'
+    rev: 'v0.12.5'
     hooks:
       - id: ruff-check
         args: [--fix, --exit-non-zero-on-fix]

pyproject.toml

@@ -103,7 +103,7 @@ show_error_codes = true
 show_error_context = true
 show_traceback = true
 pretty = true
-check_untyped_defs = false
+check_untyped_defs = true
 # Warnings
 warn_no_return = true
 warn_redundant_casts = true

src/scmrepo/git/backend/base.py

@@ -40,7 +40,7 @@ def is_ignored(self, path: str) -> bool:
 
     @property
     @abstractmethod
-    def root_dir(self) -> str:
+    def root_dir(self) -> Optional[str]:
         pass
 
     @staticmethod

src/scmrepo/git/backend/dulwich/__init__.py

@@ -204,9 +204,11 @@ def _find_submodules(self) -> dict[str, str]:
 
         Submodule paths will be relative to Git repo root.
         """
+
         from dulwich.config import ConfigFile, parse_submodules
 
         submodules: dict[str, str] = {}
+        assert self.root_dir
         config_path = os.path.join(self.root_dir, ".gitmodules")
         if os.path.isfile(config_path):
             config = ConfigFile.from_path(config_path)
@@ -218,7 +220,7 @@ def close(self):
         self.repo.close()
 
     @property
-    def root_dir(self) -> str:
+    def root_dir(self) -> Optional[str]:
         return self.repo.path
 
     @classmethod
@@ -355,6 +357,7 @@ def _expand_paths(self, paths: list[str], force: bool = False) -> Iterator[str]:
                 # path relative to the submodule root.
                 fs_path = relpath(path, self.root_dir)
                 for sm_path in self._submodules.values():
+                    assert self.root_dir
                     if fs_path.startswith(sm_path):
                         path = os.path.join(
                             self.root_dir,
@@ -648,8 +651,13 @@ def push_refspecs(  # noqa: C901
         def update_refs(refs):
             from dulwich.objects import ZERO_SHA
 
+            _refspecs = (
+                os.fsencode(refspecs)
+                if isinstance(refspecs, str)
+                else [os.fsencode(refspec) for refspec in refspecs]
+            )
             selected_refs.extend(
-                parse_reftuples(self.repo.refs, refs, refspecs, force=force)
+                parse_reftuples(self.repo.refs, refs, _refspecs, force=force)
             )
             new_refs = {}
             for lh, rh, _ in selected_refs:

src/scmrepo/git/backend/gitpython.py

@@ -161,8 +161,9 @@ def is_ignored(self, path: "Union[str, os.PathLike[str]]") -> bool:
         return bool(func(str(path)))
 
     @property
-    def root_dir(self) -> str:
-        return self.repo.working_tree_dir
+    def root_dir(self) -> Optional[str]:
+        d = self.repo.working_tree_dir
+        return os.fspath(d) if d is not None else d
 
     @staticmethod
     @requires_git
@@ -241,7 +242,7 @@ def is_sha(rev):
 
     @property
     def dir(self) -> str:
-        return self.repo.git_dir
+        return os.fspath(self.repo.git_dir)
 
     def add(
         self,
@@ -262,7 +263,7 @@ def add(
                     paths = [path for path in paths if not self.is_ignored(path)]
                 self.git.add(*paths, **kwargs)
             else:
-                self.repo.index.add(paths)
+                self.repo.index.add(paths if isinstance(paths, str) else list(paths))
         except AssertionError as exc:
             # NOTE: GitPython is not currently able to handle index version >= 3.
             # See https://github.com/iterative/dvc/issues/610 for more details.
@@ -301,7 +302,7 @@ def fetch(
             kwargs["force"] = True
         if unshallow:
             kwargs["unshallow"] = True
-        infos = self.repo.remote(name=remote).fetch(**kwargs)
+        infos = self.repo.remote(name=remote).fetch(**kwargs)  # type: ignore[arg-type]
         for info in infos:
             if info.flags & info.ERROR:
                 raise SCMError(f"fetch failed: {info.note}")
@@ -350,7 +351,7 @@ def active_branch(self):
 
     def active_branch_remote(self) -> str:
         try:
-            return self.repo.active_branch.tracking_branch()
+            return self.repo.active_branch.tracking_branch()  # type: ignore[return-value]
         except (TypeError, ValueError) as exc:
             raise SCMError("No active branch tracking remote") from exc
 
@@ -428,15 +429,15 @@ def resolve_commit(self, rev: str) -> "GitCommit":
         return GitCommit(
             commit.hexsha,
             commit.committed_date,
-            commit.committer_tz_offset,
-            commit.message,
+            commit.committer_tz_offset,  # type: ignore[arg-type]
+            commit.message,  # type: ignore[arg-type]
             [str(parent) for parent in commit.parents],
-            commit.committer.name,
-            commit.committer.email,
-            commit.author.name,
-            commit.author.email,
+            commit.committer.name,  # type: ignore[arg-type]
+            commit.committer.email,  # type: ignore[arg-type]
+            commit.author.name,  # type: ignore[arg-type]
+            commit.author.email,  # type: ignore[arg-type]
             commit.authored_date,
-            commit.author_tz_offset,
+            commit.author_tz_offset,  # type: ignore[arg-type]
         )
 
     def set_ref(
@@ -744,6 +745,8 @@ def get_tag(self, name: str) -> Optional[Union[str, "GitTag"]]:
             if not ref.tag:
                 return ref.commit.hexsha
             tag = ref.tag
+            assert tag.tagger.email
+            assert tag.tagger.name
             return GitTag(
                 tag.tag,
                 tag.hexsha,