fix: resolve collection of CLI and UI bugs (#3168, #3105, #3139)

Author: deepshekhardas

apps/webapp/app/components/RuntimeIcon.tsx

@@ -29,15 +29,10 @@ export function RuntimeIcon({
 }: RuntimeIconProps) {
   const parsedRuntime = parseRuntime(runtime);
 
-  // Default to Node.js if no runtime is specified
-  const effectiveRuntime = parsedRuntime || {
-    runtime: "node" as const,
-    originalRuntime: "node",
-    displayName: "Node.js",
-  };
-
-  const icon = getIcon(effectiveRuntime.runtime, className);
-  const formattedText = formatRuntimeWithVersion(effectiveRuntime.originalRuntime, runtimeVersion);
+  const icon = parsedRuntime ? getIcon(parsedRuntime.runtime, className) : <span className="text-text-dimmed">–</span>;
+  const formattedText = parsedRuntime
+    ? formatRuntimeWithVersion(parsedRuntime.originalRuntime, runtimeVersion)
+    : "Unknown";
 
   if (withLabel) {
     return (

packages/cli-v3/src/deploy/buildImage.ts

@@ -486,47 +486,57 @@ async function localBuildImage(options: SelfHostedBuildImageOptions): Promise<Bu
       };
     }
 
-    const [credentialsError, credentials] = await tryCatch(
-      getDockerUsernameAndPassword(apiClient, deploymentId)
-    );
+    let credentials;
+    if (cloudRegistryHost.endsWith("amazonaws.com")) {
+      const [credentialsError, result] = await tryCatch(
+        getDockerUsernameAndPassword(apiClient, deploymentId)
+      );
 
-    if (credentialsError) {
-      return {
-        ok: false as const,
-        error: `Failed to get docker credentials: ${credentialsError.message}`,
-        logs: "",
-      };
+      if (credentialsError) {
+        return {
+          ok: false as const,
+          error: `Failed to get docker credentials: ${credentialsError.message}`,
+          logs: "",
+        };
+      }
+      credentials = result;
     }
 
-    logger.debug(`Logging in to docker registry: ${cloudRegistryHost}`);
+    if (credentials) {
+      logger.debug(`Logging in to docker registry: ${cloudRegistryHost}`);
 
-    const loginProcess = x(
-      "docker",
-      ["login", "--username", credentials.username, "--password-stdin", cloudRegistryHost],
-      {
-        nodeOptions: {
-          cwd: options.cwd,
-        },
-      }
-    );
+      const loginProcess = x(
+        "docker",
+        ["login", "--username", credentials.username, "--password-stdin", cloudRegistryHost],
+        {
+          nodeOptions: {
+            cwd: options.cwd,
+          },
+        }
+      );
 
-    loginProcess.process?.stdin?.write(credentials.password);
-    loginProcess.process?.stdin?.end();
+      loginProcess.process?.stdin?.write(credentials.password);
+      loginProcess.process?.stdin?.end();
 
-    for await (const line of loginProcess) {
-      errors.push(line);
-      logger.debug(line);
-    }
+      for await (const line of loginProcess) {
+        errors.push(line);
+        logger.debug(line);
+      }
 
-    if (loginProcess.exitCode !== 0) {
-      return {
-        ok: false as const,
-        error: `Failed to login to registry: ${cloudRegistryHost}`,
-        logs: extractLogs(errors),
-      };
-    }
+      if (loginProcess.exitCode !== 0) {
+        return {
+          ok: false as const,
+          error: `Failed to login to registry: ${cloudRegistryHost}`,
+          logs: extractLogs(errors),
+        };
+      }
 
-    options.onLog?.(`Successfully logged in to the remote registry`);
+      options.onLog?.(`Successfully logged in to the remote registry`);
+    } else {
+      logger.debug(
+        `Skipping automatic registry login for ${cloudRegistryHost}. Please ensure you are logged in locally.`
+      );
+    }
   }
 
   const projectCacheRef = getProjectCacheRefFromImageTag(imageTag);
@@ -550,13 +560,12 @@ async function localBuildImage(options: SelfHostedBuildImageOptions): Promise<Bu
     options.noCache ? "--no-cache" : undefined,
     ...(useRegistryCache
       ? [
-          "--cache-to",
-          `type=registry,mode=max,image-manifest=true,oci-mediatypes=true,ref=${projectCacheRef}${
-            cacheCompression === "zstd" ? ",compression=zstd" : ""
-          }`,
-          "--cache-from",
-          `type=registry,ref=${projectCacheRef}`,
-        ]
+        "--cache-to",
+        `type=registry,mode=max,image-manifest=true,oci-mediatypes=true,ref=${projectCacheRef}${cacheCompression === "zstd" ? ",compression=zstd" : ""
+        }`,
+        "--cache-from",
+        `type=registry,ref=${projectCacheRef}`,
+      ]
       : []),
     "--output",
     outputOptions.join(","),