Skip to content

Commit 838be18

Browse files
fix(core,cli): resolve S2 dependency version drift and align SDK schemas
1 parent 64c0271 commit 838be18

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

packages/cli-v3/src/commands/deploy.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,9 +1149,9 @@ async function handleNativeBuildServerDeploy({
11491149
const [readSessionError, readSession] = await tryCatch(
11501150
stream.readSession(
11511151
{
1152-
seq_num: 0,
1153-
clamp: true,
1154-
wait: 60 * 20, // 20 minutes
1152+
start: {
1153+
from: { seqNum: 0 },
1154+
},
11551155
},
11561156
{ signal: abortController.signal }
11571157
)
@@ -1187,7 +1187,7 @@ async function handleNativeBuildServerDeploy({
11871187

11881188
switch (event.type) {
11891189
case "log": {
1190-
if (record.seq_num === 0) {
1190+
if (record.seqNum === 0) {
11911191
$queuedSpinner.stop("Build started");
11921192
console.log("│");
11931193
queuedSpinnerStopped = true;

packages/core/src/v3/realtimeStreams/streamsWriterV2.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class StreamsWriterV2<T = any> implements StreamsWriter {
135135
const stream = basin.stream(this.options.stream);
136136

137137
const session = await stream.appendSession({
138-
maxQueuedBytes: this.maxInflightBytes,
138+
maxInflightBytes: this.maxInflightBytes,
139139
});
140140

141141
this.sessionWritable = session.writable;
@@ -152,7 +152,9 @@ export class StreamsWriterV2<T = any> implements StreamsWriter {
152152
return;
153153
}
154154
// Convert each chunk to JSON string and wrap in AppendRecord
155-
controller.enqueue(AppendRecord.make(JSON.stringify({ data: chunk, id: nanoid(7) })));
155+
controller.enqueue(
156+
AppendRecord.string({ body: JSON.stringify({ data: chunk, id: nanoid(7) }) })
157+
);
156158
},
157159
})
158160
)
@@ -169,9 +171,9 @@ export class StreamsWriterV2<T = any> implements StreamsWriter {
169171
const lastAcked = session.lastAckedPosition();
170172

171173
if (lastAcked?.end) {
172-
const recordsWritten = lastAcked.end.seq_num;
174+
const recordsWritten = lastAcked.end.seqNum;
173175
this.log(
174-
`[S2MetadataStream] Written ${recordsWritten} records, ending at seq_num=${lastAcked.end.seq_num}`
176+
`[S2MetadataStream] Written ${recordsWritten} records, ending at seqNum=${lastAcked.end.seqNum}`
175177
);
176178
}
177179
} catch (error) {

0 commit comments

Comments
 (0)