Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Puppeteer #3022

Open
coliff opened this issue Nov 25, 2024 · 1 comment
Open

Update Puppeteer #3022

coliff opened this issue Nov 25, 2024 · 1 comment
Labels
bug Something is wrong and needs to be addressed dependencies Pull requests that update a dependency file

Comments

@coliff
Copy link
Member

coliff commented Nov 25, 2024

We should update Puppeteer to the latest version (we were stuck using an older version before due to being on the old Storybook which was using Node v16.x.

image
@coliff coliff added the dependencies Pull requests that update a dependency file label Nov 25, 2024
@coliff coliff linked a pull request Nov 25, 2024 that will close this issue
Bump puppeteer from v19.11.1 to v23.9.0 #3023
Closed
@coliff
Copy link
Member Author

coliff commented Nov 25, 2024 •
edited
Loading

It fails with this change:
image

image

@coliff coliff added the bug Something is wrong and needs to be addressed label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is wrong and needs to be addressed dependencies Pull requests that update a dependency file
Projects
Modus Web Components
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump puppeteer from v19.11.1 to v23.9.0 trimble-oss/modus-web-components
1 participant
@coliff