Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast: message is too long and is not formatted correctly #3137

Open
2 tasks done
DancuVladTrimble opened this issue Jan 21, 2025 · 4 comments
Open
2 tasks done

Toast: message is too long and is not formatted correctly #3137

DancuVladTrimble opened this issue Jan 21, 2025 · 4 comments
Assignees
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@DancuVladTrimble
Copy link
Contributor

Prerequisites

Describe the issue

The message is too long for the red background and is not formatted correctly.

Image

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

High

What product/project are you using Modus Components for ?

TSL(Trade Service Live)

What is your team/division name ?

Con-Artist(MEP Construction)

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@DancuVladTrimble DancuVladTrimble added the bug Something is wrong and needs to be addressed label Jan 21, 2025
Copy link

Hello @DancuVladTrimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jan 21, 2025
@coliff coliff self-assigned this Jan 27, 2025
@coliff coliff moved this from In Review to To Do in Modus Web Components Jan 27, 2025
@coliff coliff changed the title Provide a general summary of the issue Toast: message is too long for the red background and is not formatted correctly Jan 27, 2025
@coliff coliff moved this from To Do to In Progress in Modus Web Components Jan 30, 2025
@coliff coliff changed the title Toast: message is too long for the red background and is not formatted correctly Toast: message is too long and is not formatted correctly Feb 20, 2025
@coliff
Copy link
Member

coliff commented Feb 20, 2025

@mitch-trimble We can change a few CSS rules so it displays like this - what do you think?

Image

remove from .text:

white-space: nowrap;
overflow: hidden;

add to .modus-toast:

min-height: 2.6875rem;

(and remove height: 2.6875rem;)

@DancuVladTrimble
Copy link
Contributor Author

DancuVladTrimble commented Feb 20, 2025 via email

@DancuVladTrimble
Copy link
Contributor Author

DancuVladTrimble commented Feb 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Progress
Development

No branches or pull requests

3 participants