Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: inline editing (select) - allow row based options #3159

Open
2 tasks done
janwiebe-glasbergen opened this issue Feb 4, 2025 · 1 comment
Open
2 tasks done
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-table Modus Table component development

Comments

@janwiebe-glasbergen
Copy link
Contributor

Prerequisites

Proposal

It is currently not possible to have different values, per row, when using the inline editing for the cellEditorType: 'select'

It would be great if the ModusTableCellSelectEditorArgs could be extended with an option func.

Something like:

export type ModusTableCellSelectEditorArgs = {
    options?: unknown[]; 
    optionsFunc?: (rowId: number) => unknown[];
    optionsDisplayProp?: string; 
    placeholder?: string 
};

Motivation and context

This feature would make it possible for us to build a table were options differ from row to row.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Nova

What is your team/division name ?

ACDC

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

Copy link

github-actions bot commented Feb 4, 2025

Hello @janwiebe-glasbergen! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Feb 4, 2025
@coliff coliff added the modus-table Modus Table component development label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-table Modus Table component development
Projects
Status: In Review
Development

No branches or pull requests

2 participants