Skip to content

Commit 81c5a13

Browse files
authored
Don't require https ports in additionalExposedPorts when https is enabled
1 parent 1ff5b92 commit 81c5a13

File tree

5 files changed

+20
-7
lines changed

5 files changed

+20
-7
lines changed

charts/trino/templates/deployment-coordinator.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,11 @@ spec:
197197
- name: http
198198
containerPort: {{ .Values.service.port }}
199199
protocol: TCP
200+
{{- if .Values.server.config.https.enabled }}
201+
- name: https
202+
containerPort: {{ .Values.server.config.https.port }}
203+
protocol: TCP
204+
{{- end }}
200205
{{- if $coordinatorJmx.enabled }}
201206
- name: jmx-registry
202207
containerPort: {{ $coordinatorJmx.registryPort }}

charts/trino/templates/deployment-worker.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,11 @@ spec:
171171
- name: http
172172
containerPort: {{ .Values.service.port }}
173173
protocol: TCP
174+
{{- if .Values.server.config.https.enabled }}
175+
- name: https
176+
containerPort: {{ .Values.server.config.https.port }}
177+
protocol: TCP
178+
{{- end }}
174179
{{- if $workerJmx.enabled }}
175180
- name: jmx-registry
176181
containerPort: {{ $workerJmx.registryPort }}

charts/trino/templates/ingress.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ spec:
3232
service:
3333
name: {{ include "trino.fullname" $ }}
3434
port:
35+
{{- if $.Values.server.config.https.enabled }}
36+
number: {{ $.Values.server.config.https.port }}
37+
{{- else }}
3538
number: {{ $.Values.service.port }}
39+
{{- end }}
3640
{{- end }}
3741
{{- end }}
3842
{{- end }}

charts/trino/templates/service-coordinator.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ spec:
1919
{{- if .Values.service.nodePort }}
2020
nodePort: {{ .Values.service.nodePort }}
2121
{{- end }}
22+
{{- if .Values.server.config.https.enabled }}
23+
- port: {{ .Values.server.config.https.port }}
24+
targetPort: https
25+
protocol: TCP
26+
name: https
27+
{{- end }}
2228
{{- if $coordinatorJmx.exporter.enabled }}
2329
- port: {{ $coordinatorJmx.exporter.port }}
2430
targetPort: jmx-exporter

tests/trino/test-values.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,6 @@ coordinator:
100100
mountPath: /etc/trino/generated
101101
readOnly: false
102102

103-
additionalExposedPorts:
104-
https:
105-
servicePort: 8443
106-
name: https
107-
port: 8443
108-
protocol: TCP
109-
110103
annotations:
111104
custom/name: value
112105

0 commit comments

Comments
 (0)