Refactor LbAuthorizer logging for clarity and consistency

Author: vishnu-lab

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbAuthorizer.java

@@ -37,27 +37,27 @@ public boolean authorize(LbPrincipal principal,
     {
         switch (role) {
             case "ADMIN":
-                log.info("User '%s' with memberOf(%s) was identified as ADMIN(%s)",
-                        principal.getName(), principal.getMemberOf(), configuration.getAdmin());
-                return principal.getMemberOf()
-                        .filter(m -> m.matches(configuration.getAdmin()))
-                        .isPresent();
+                return hasRole(principal, role, configuration.getAdmin());
             case "USER":
-                log.info("User '%s' with memberOf(%s) identified as USER(%s)",
-                        principal.getName(), principal.getMemberOf(), configuration.getUser());
-                return principal.getMemberOf()
-                        .filter(m -> m.matches(configuration.getUser()))
-                        .isPresent();
+                return hasRole(principal, role, configuration.getUser());
             case "API":
-                log.info("User '%s' with memberOf(%s) identified as API(%s)",
-                        principal.getName(), principal.getMemberOf(), configuration.getApi());
-                return principal.getMemberOf()
-                        .filter(m -> m.matches(configuration.getApi()))
-                        .isPresent();
+                return hasRole(principal, role, configuration.getApi());
             default:
                 log.warn("User '%s' with role %s has no regex match based on ldap search",
                         principal.getName(), role);
                 return false;
         }
     }
+
+    private static boolean hasRole(LbPrincipal principal, String role, String regex)
+    {
+        boolean matched = principal.getMemberOf()
+                .filter(m -> m.matches(regex))
+                .isPresent();
+        if (matched) {
+            log.info("User '%s' with memberOf(%s) is identified as %s(%s)",
+                    principal.getName(), principal.getMemberOf(), role, regex);
+        }
+        return matched;
+    }
 }