Fix DevelopmentServer plugin.dir configuration

Author: wendigo

lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/ClosingBinder.java

@@ -85,6 +85,11 @@ public <T> void registerResource(Key<T> key, Consumer<? super T> close)
         closeables.addBinding().toProvider(new ResourceCloser<T>(key, close));
     }
 
+    public void registerCloseable(AutoCloseable instance)
+    {
+        closeables.addBinding().toInstance(instance);
+    }
+
     private static class ResourceCloser<T>
             implements Provider<AutoCloseable>
     {

testing/trino-server-dev/pom.xml

@@ -40,6 +40,11 @@
             <artifactId>trino-main</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>io.trino</groupId>
+            <artifactId>trino-plugin-toolkit</artifactId>
+        </dependency>
+
         <dependency>
             <groupId>io.trino</groupId>
             <artifactId>trino-spi</artifactId>

testing/trino-server-dev/src/main/java/io/trino/server/DevelopmentServer.java

@@ -18,8 +18,14 @@
 import com.google.inject.Scopes;
 import io.trino.server.PluginManager.PluginsProvider;
 
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
 import static com.google.inject.multibindings.OptionalBinder.newOptionalBinder;
 import static io.airlift.configuration.ConfigBinder.configBinder;
+import static io.trino.plugin.base.ClosingBinder.closingBinder;
 
 public final class DevelopmentServer
         extends Server
@@ -29,11 +35,24 @@ private DevelopmentServer() {}
     @Override
     protected Iterable<? extends Module> getAdditionalModules()
     {
-        return ImmutableList.of(binder -> {
-            newOptionalBinder(binder, PluginsProvider.class).setBinding()
-                    .to(DevelopmentPluginsProvider.class).in(Scopes.SINGLETON);
-            configBinder(binder).bindConfig(DevelopmentLoaderConfig.class);
-        });
+        try {
+            Path pluginPath = Files.createTempDirectory("plugins");
+
+            return ImmutableList.of(binder -> {
+                newOptionalBinder(binder, PluginsProvider.class).setBinding()
+                        .to(DevelopmentPluginsProvider.class).in(Scopes.SINGLETON);
+                configBinder(binder).bindConfig(DevelopmentLoaderConfig.class);
+
+                // Use a temporary directory to satisfy configuration validation
+                configBinder(binder).bindConfigDefaults(ServerPluginsProviderConfig.class, config ->
+                        config.setInstalledPluginsDirs(ImmutableList.of(pluginPath.toFile())));
+
+                closingBinder(binder).registerCloseable(() -> Files.deleteIfExists(pluginPath));
+            });
+        }
+        catch (IOException e) {
+            throw new UncheckedIOException(e);
+        }
     }
 
     public static void main(String[] args)