Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change length of client_info column in MySQL event listener #22362

Open
vjain143 opened this issue Jun 11, 2024 · 3 comments · May be fixed by #23427
Open

Change length of client_info column in MySQL event listener #22362

vjain143 opened this issue Jun 11, 2024 · 3 comments · May be fixed by #23427
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vjain143
Copy link

Change length of clintInfo Column in trino_event db trino_queries table from archer(255) to varcher(16777215)

Airflow populate this field and put the information below if dag name is longer and more than 255 event listener is unable to insert

{"dag_owner": \"airflow\", | "dag "{\"dag id\": \"create iceberg_tables_xyz\": \ "manual myk8s\", "create_mv "execution_date)": 1"2023-07-11T03:53:41.939266+00:00\", |"task_id\": 2023-07-1103: 53:41.939266+00:00\", iceberg_mytable"，V"try_ number": \"1\"}",
@ebyhr
Copy link
Member

ebyhr commented Jun 12, 2024 •
edited
Loading

You're using MySQL event listener and clintInfo means client_info, right? Could you please clarify the plugin name in PR title and description?

@monmooney5523
Copy link

Yes we are using the MySQL Event Listener - client_info is correct

@ebyhr ebyhr changed the title Change length of clintInfo Column Change length of client_info column in MySQL event listener Jun 24, 2024
@ebyhr ebyhr changed the title Change length of client_info column in MySQL event listener Change length of client_info column in MySQL event listener Jun 24, 2024
@hashhar hashhar added bug Something isn't working good first issue Good for newcomers labels Sep 3, 2024
@avirlrma
Copy link

@ebyhr I can pick this up. I think we can just make the client_info a MEDIUMTEXT column, that will be in accordance with other columns also.

Reference: https://github.com/trinodb/trino/blob/master/plugin/trino-mysql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/QueryDao.java#L24

@avirlrma avirlrma linked a pull request Sep 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change client_info column_type to MEDIUMTEXT avirlrma/trino
5 participants
@vjain143 @ebyhr @hashhar @avirlrma @monmooney5523