Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-strict option to add_files_from_table procedure #23677

Open
ebyhr opened this issue Oct 4, 2024 · 0 comments
Open

Add non-strict option to add_files_from_table procedure #23677

ebyhr opened this issue Oct 4, 2024 · 0 comments
Labels
iceberg Iceberg connector

Comments

@ebyhr
Copy link
Member

ebyhr commented Oct 4, 2024

The procedure throws an exception if column definition between a source and a target table doesn't exctly match. We could add a function argument which tweaks the validation because the schema can be a little different.

Probably, we should still disallow the following situation even if the option is enabled:

  • schema is completely different: (a int) ↔︎ (y string)
  • different column types with same column name: (a int) ↔︎ (a string)
    • this is allowed in Spark's add_files procedure, but it throws an exception when reading tables

Relates to #22751 (comment) by @cwsteinbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iceberg Iceberg connector
Development

No branches or pull requests

1 participant