Make max_points_per_cell work with templates
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efaulhaber
commented
Nov 12, 2024
Comment on lines
+51
to
+52
| min_corner = SVector(Tuple(min_corner .- 1.0f-3 * search_radius)) | ||
| max_corner = SVector(Tuple(max_corner .+ 1.0f-3 * search_radius)) |
There was a problem hiding this comment.
This is the only change that is needed to make everything work with Float32, so I just included it here.
It does not change anything when search_radius is Float64.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 88.19% 88.13% -0.06%
==========================================
Files 15 15
Lines 483 489 +6
==========================================
+ Hits 426 431 +5
- Misses 57 58 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svchb
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.