Skip to content

Commit a30cb97

Browse files
committed
request arg can be renamed
1 parent 73fe31e commit a30cb97

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

sanicargs/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ async def generate_csv(request, query: str, businessunitid: str):
4848
(name, p.annotation, p.default)
4949
for name, p in notations.parameters.items()
5050
]
51+
request_arg_name = inspect.getfullargspec(func)[0][0]
52+
5153

5254
async def inner(request, *old_args, **route_parameters):
5355
kwargs = {}
@@ -57,8 +59,8 @@ async def inner(request, *old_args, **route_parameters):
5759
raw_value = request.args.get(name, None)
5860

5961
# provided in route
60-
if name in route_parameters or name=="request":
61-
if name=="request":
62+
if name in route_parameters or name==request_arg_name:
63+
if name==request_arg_name:
6264
continue
6365
raw_value = route_parameters[name]
6466

tests/test_sanicargs.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
from sanicargs import parse_query_args, fields
66
from sanic.websocket import WebSocketProtocol
77
from sanic.exceptions import InvalidUsage
8+
from sanic import request
9+
810
import datetime
911

1012

@@ -34,13 +36,13 @@ async def test_date(request, test: datetime.date):
3436

3537
@app.route("/list", methods=['GET'])
3638
@parse_query_args
37-
async def test_list(request, test: fields.List[str] = None):
39+
async def test_list(req, test: fields.List[str] = None):
3840
return response.json({'test': test})
3941

4042
@app.route("/all", methods=['GET'])
4143
@parse_query_args
4244
async def test_all(
43-
request,
45+
req: request,
4446
a: int,
4547
b: str,
4648
c: datetime.datetime,

0 commit comments

Comments
 (0)