Skip to content

[C++]: Fix incorrect use of noexcept specifier #3347

@satoshiotomakan

Description

@satoshiotomakan

Describe the bug
WC makes the end-user app crashing because of the incorrect use of C++ noexcept specifier which ignores throw exceptions.

To Reproduce
For example, pass an incorrect EOS signature:

tx.signatures.emplace_back(Signature(signature, type));

Expected behavior
WC should either throw an exception or return an error in SigningOutput { error, error_message } Protobuf message.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions