Skip to content

v1.2 PR and unit testing loose ends #541

@jtlangevin

Description

@jtlangevin

Unit Tests

Needed for PR #530, #531, #532, #533, #534.

Unaddressed Comments in PRs

For #532:

Break up the apply_incentives function: #532 (comment)
Use dicts or data class to handle key parameters of state-level drivers (note that this applies to other PRs that involve import of state-level drivers:
#532 (comment)
#532 (comment)

For #534:

Consider existing comments about trim_results option in #505: #534 (comment)
Create separate module/py file to handle BPS and codes: #534 (comment)
Use variables instead of dict lookups for deeply nested logic #534 (comment)
Is there a better way to pass through code/BPS inputs with so many similar variable names that are hard to track? #534 (comment)

Sub-issues

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions