Skip to content

Commit de530cb

Browse files
MustafaMulla29“mustafa”
and
“mustafa”
authored
Modified bundle-size.yml to post if gt 10kb (#584)
* Modified bundle-size.yml to post if gt 10kb * Fix workflow condition syntax in bundle-size.yml --------- Co-authored-by: “mustafa” <“[email protected]”>
1 parent 6119a13 commit de530cb

File tree

1 file changed

+25
-28
lines changed

1 file changed

+25
-28
lines changed

.github/workflows/bundle-size.yml

+25-28
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ jobs:
3636
- name: Get base bundle size
3737
id: base-bundle-size
3838
run: |
39-
echo "base=$(du -sh dist | cut -f1)" >> $GITHUB_OUTPUT
39+
echo "base=$(du -sk dist | cut -f1)" >> $GITHUB_OUTPUT
4040
4141
- name: Get base install size
4242
id: base-install-size
4343
run: |
44-
echo "base=$(bunx howfat -r simple . | grep 'Size:' | awk '{print $2}')" >> $GITHUB_OUTPUT
44+
echo "base=$(bunx howfat -r simple . | grep 'Size:' | awk '{print $2}' | sed 's/K//')" >> $GITHUB_OUTPUT
4545
4646
- name: Checkout PR branch
4747
uses: actions/checkout@v3
@@ -55,41 +55,38 @@ jobs:
5555
- name: Get PR bundle size
5656
id: pr-bundle-size
5757
run: |
58-
echo "pr=$(du -sh dist | cut -f1)" >> $GITHUB_OUTPUT
58+
echo "pr=$(du -sk dist | cut -f1)" >> $GITHUB_OUTPUT
5959
6060
- name: Get PR install size and full howfat output
6161
id: pr-install-size
6262
run: |
63-
echo "pr=$(bunx howfat -r simple . | grep 'Size:' | awk '{print $2}')" >> $GITHUB_OUTPUT
63+
echo "pr=$(bunx howfat -r simple . | grep 'Size:' | awk '{print $2}' | sed 's/K//')" >> $GITHUB_OUTPUT
6464
echo "full_output<<EOF" >> $GITHUB_OUTPUT
6565
bunx howfat -r table . >> $GITHUB_OUTPUT
6666
echo "EOF" >> $GITHUB_OUTPUT
6767
6868
- name: Calculate bundle size difference
6969
id: bundle-size-diff
7070
run: |
71-
base_size=$(echo ${{ steps.base-bundle-size.outputs.base }} | sed 's/[^0-9.]*//g')
72-
pr_size=$(echo ${{ steps.pr-bundle-size.outputs.pr }} | sed 's/[^0-9.]*//g')
73-
diff=$(echo "$pr_size - $base_size" | bc)
74-
if (( $(echo "$diff > 0" | bc -l) )); then
75-
echo "diff=+$diff" >> $GITHUB_OUTPUT
76-
else
77-
echo "diff=$diff" >> $GITHUB_OUTPUT
78-
fi
71+
base_size=${{ steps.base-bundle-size.outputs.base }}
72+
pr_size=${{ steps.pr-bundle-size.outputs.pr }}
73+
diff=$((pr_size - base_size))
74+
echo "diff=$diff" >> $GITHUB_OUTPUT
7975
8076
- name: Calculate install size difference
8177
id: install-size-diff
8278
run: |
83-
base_size=$(echo ${{ steps.base-install-size.outputs.base }} | sed 's/[^0-9.]*//g')
84-
pr_size=$(echo ${{ steps.pr-install-size.outputs.pr }} | sed 's/[^0-9.]*//g')
79+
base_size=${{ steps.base-install-size.outputs.base }}
80+
pr_size=${{ steps.pr-install-size.outputs.pr }}
8581
diff=$(echo "$pr_size - $base_size" | bc)
86-
if (( $(echo "$diff > 0" | bc -l) )); then
87-
echo "diff=+$diff" >> $GITHUB_OUTPUT
88-
else
89-
echo "diff=$diff" >> $GITHUB_OUTPUT
90-
fi
91-
92-
- name: Update comment
82+
echo "diff=$diff" >> $GITHUB_OUTPUT
83+
84+
- name: Conditionally Update PR Comment
85+
if: |
86+
steps.bundle-size-diff.outputs.diff | tonumber >= 10
87+
or steps.bundle-size-diff.outputs.diff | tonumber <= -10
88+
or steps.install-size-diff.outputs.diff | tonumber >= 10
89+
or steps.install-size-diff.outputs.diff | tonumber <= -10
9390
uses: mshick/add-pr-comment@v2
9491
env:
9592
GITHUB_TOKEN: ${{ secrets.TSCIRCUIT_BOT_GITHUB_TOKEN }}
@@ -98,14 +95,14 @@ jobs:
9895
message: |
9996
## Size Report
10097
### Bundle Size
101-
- Base branch size: ${{ steps.base-bundle-size.outputs.base }}
102-
- PR branch size: ${{ steps.pr-bundle-size.outputs.pr }}
103-
- Difference: ${{ steps.bundle-size-diff.outputs.diff }}
98+
- Base branch size: ${{ steps.base-bundle-size.outputs.base }} KB
99+
- PR branch size: ${{ steps.pr-bundle-size.outputs.pr }} KB
100+
- Difference: ${{ steps.bundle-size-diff.outputs.diff }} KB
104101
105102
### Install Size
106-
- Base branch size: ${{ steps.base-install-size.outputs.base }}
107-
- PR branch size: ${{ steps.pr-install-size.outputs.pr }}
108-
- Difference: ${{ steps.install-size-diff.outputs.diff }}
103+
- Base branch size: ${{ steps.base-install-size.outputs.base }} KB
104+
- PR branch size: ${{ steps.pr-install-size.outputs.pr }} KB
105+
- Difference: ${{ steps.install-size-diff.outputs.diff }} KB
109106
110107
### Full Howfat Output (PR Branch)
111108
```
@@ -114,4 +111,4 @@ jobs:
114111
(aside)
115112
```
116113
proxy-url: https://add-pr-comment-proxy-tscircuit.vercel.app/api
117-
allow-repeats: false
114+
allow-repeats: false

0 commit comments

Comments
 (0)