Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schematic_port.facing_direction is not computed properly, causing netlabels to appear at the wrong orientation #266

Closed
seveibar opened this issue Nov 10, 2024 · 5 comments · Fixed by #269

Comments

@seveibar
Copy link
Contributor

seveibar commented Nov 10, 2024

Image

/bounty $15

Copy link

algora-pbc bot commented Nov 10, 2024

💎 $15 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #266 with your implementation plan
  2. Submit work: Create a pull request including /claim #266 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/core!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @ShiboSoftwareDev #269

@seveibar
Copy link
Contributor Author

In the snapshots directory there are existing reproductions

@DhairyaMajmudar
Copy link
Contributor

@seveibar while inspecting the schematic_ports in circuit-json codebase I observe that facing_direction is made an optional field. Does making it required can be a solution for this issue ?

https://github.com/tscircuit/circuit-json/blob/272ad2bbd054e752404e20827150544807b20c4b/src/schematic/schematic_port.ts#L11

Copy link

algora-pbc bot commented Nov 10, 2024

💡 @ShiboSoftwareDev submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Nov 11, 2024

🎉🎈 @ShiboSoftwareDev has been awarded $15! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants