Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schPinStyle should accept pin labels as keys (not just pin numbers) #301

Closed
seveibar opened this issue Nov 14, 2024 · 3 comments
Closed

Comments

@seveibar
Copy link
Contributor

seveibar commented Nov 14, 2024

Try to keep the solution not super hacky. schPortArrangement already has similar functionality where you can specify pin numbers or labels and there's some kind of utility function for it.

/bounty $10

Copy link

algora-pbc bot commented Nov 16, 2024

💎 $10 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #301 with your implementation plan
  2. Submit work: Create a pull request including /claim #301 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/core!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @ChiragAgg5k Nov 17, 2024, 6:56:48 AM WIP
🟢 @DhairyaMajmudar Nov 17, 2024, 2:32:57 PM WIP

@ChiragAgg5k
Copy link

ChiragAgg5k commented Nov 17, 2024

/attempt #301

will try replicate functionality similar to schPortArrangement

@DhairyaMajmudar
Copy link
Contributor

DhairyaMajmudar commented Nov 17, 2024

/attempt #301

Algora profile Completed bounties Tech Active attempts Options
@DhairyaMajmudar    1 tscircuit bounty
+ 1 bounty from 1 project
JavaScript, TypeScript,
HTML & more
﹟105
Cancel attempt

devin-ai-integration bot added a commit that referenced this issue Jan 2, 2025
- Add support for using pin labels as keys in schPinStyle
- Add test to verify pin label support in schPinStyle
- Merge styles when multiple keys (pin numbers/labels) refer to same pin

Fixes #301

Co-Authored-By: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants