Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid props for trace "unnamed" (improve error message by naming specific invalid props) #593

Closed
seveibar opened this issue Feb 1, 2025 · 5 comments

Comments

@seveibar
Copy link
Contributor

seveibar commented Feb 1, 2025

You may need to fix it in NormalComponent or PrimitiveComponent not sure

Image

Make sure to have a test with an invalid prop

/bounty $15

Copy link

algora-pbc bot commented Feb 1, 2025

## 💎 $15 bounty • tscircuit

### Steps to solve:
1. Start working: Comment /attempt #593 with your implementation plan
2. Submit work: Create a pull request including /claim #593 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/core!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @ArnavK-09 #21

Copy link

algora-pbc bot commented Feb 1, 2025

💡 @ArnavK-09 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@ArnavK-09
Copy link
Contributor

You may need to fix it in NormalComponent or PrimitiveComponent not sure

Image

Make sure to have a test with an invalid prop

@seveibar

Image

i think it includes prop name, like maxLength its from the svg side that it doesnt include full errors, i tried to fix it,

is this the problem or anything else in the code??

tscircuit/svg.tscircuit.com#21

@seveibar
Copy link
Contributor Author

seveibar commented Feb 2, 2025

@ArnavK-09 you're right. The error message should use ellipsis

Copy link

algora-pbc bot commented Feb 2, 2025

🎉🎈 @ArnavK-09 has been awarded $15! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants