-
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededsweepAssigns Sweep to an issue or pull request.Assigns Sweep to an issue or pull request.
Description
The library actually is not very compatible with older Angular versions, I think this can be improved somehow.
If there are some code changes to improve this, these are necessary. If it's not possible because of Angular breaking changes between major versions, multiple libraries need to be released and maintained (following Angular LTS rules, minimum).
The first idea that came to my mind is to create a package for every major version, but this can be too much work. This will result in multiple demo apps too.
Checklist
-
packages/angular-7/package.json
✅ Commit5af6fc1
-
packages/angular-8/package.json
✅ Commitad5481a
-
packages/angular-9/package.json
✅ Commitbe7976e
-
packages/angular-10/package.json
✅ Commit5a089c9
-
packages/angular-11/package.json
✅ Commit908142a
-
packages/angular-12/package.json
✅ Commitb60f655
-
angular.json
✅ Commit1fa1365
-
README.md
✅ Commitf6379cb
-
apps/ionic-demo/src/app/app.module.ts
✅ Commit51555d5
-
apps/angular-demo/src/app/app.module.ts
✅ Commita4dce27
-
apps/ionic-demo/src/app/tab1/tab1.page.ts
✅ Commitbbc17dd
-
apps/ionic-demo/src/app/tab2/tab2.page.ts
❌ Failed -
apps/ionic-demo/src/app/tab3/tab3.page.ts
❌ Failed -
apps/ionic-demo/src/app/tabs/tabs.page.ts
❌ Failed -
apps/angular-demo/src/app/app.component.ts
❌ Failed -
apps/angular-demo/src/app/app.component.spec.ts
❌ Failed -
apps/ionic-demo/src/app/app.component.ts
❌ Failed -
apps/ionic-demo/src/app/app.component.spec.ts
✅ Commit38215b6
-
apps/ionic-demo/src/app/explore-container/explore-container.component.ts
❌ Failed -
apps/ionic-demo/src/app/tab1/tab1.page.spec.ts
❌ Failed -
apps/ionic-demo/src/app/tab2/tab2.page.spec.ts
✅ Commit2f0a5e1
-
apps/ionic-demo/src/app/tab3/tab3.page.spec.ts
❌ Failed -
apps/ionic-demo/src/app/tabs/tabs.page.spec.ts
❌ Failed -
apps/ionic-demo/src/app/tabs/tabs.page.html
❌ Failed -
apps/ionic-demo/src/app/tabs/tabs.page.scss
❌ Failed -
apps/ionic-demo/src/app/tabs/tabs.page.ts
❌ Failed -
apps/angular-demo/src/app/app.component.html
✅ Commit3f0731f
-
apps/ionic-demo/src/app/app.component.html
❌ Failed -
apps/angular-demo/src/app/app.component.css
❌ Failed -
apps/ionic-demo/src/app/app.component.scss
❌ Failed -
apps/angular-demo/src/styles.css
❌ Failed -
apps/ionic-demo/src/global.scss
❌ Failed -
apps/ionic-demo/src/theme/variables.scss
✅ Commit577092d
-
apps/ionic-demo/src/polyfills.ts
✅ Commit706df19
-
apps/angular-demo/src/polyfills.ts
❌ Failed -
apps/ionic-demo/karma.conf.js
✅ Commit1ef1689
-
apps/angular-demo/karma.conf.js
✅ Commit1abd3f9
-
apps/ionic-demo/tsconfig.app.json
❌ Failed -
apps/angular-demo/tsconfig.app.json
❌ Failed -
apps/ionic-demo/tsconfig.spec.json
✅ Commit877b002
-
apps/angular-demo/tsconfig.spec.json
✅ Commit34177f5
-
apps/ionic-demo/tsconfig.json
✅ Commitbca0ae2
-
apps/angular-demo/tsconfig.json
❌ Failed -
apps/ionic-demo/package.json
✅ Commit756b5fb
-
apps/angular-demo/package.json
❌ Failed -
apps/ionic-demo/ionic.config.json
❌ Failed -
apps/ionic-demo/capacitor.config.ts
❌ Failed -
apps/ionic-demo/e2e/protractor.conf.js
✅ Commit5d76a04
-
apps/ionic-demo/e2e/src/app.e2e-spec.ts
✅ Commit261d53c
-
apps/ionic-demo/e2e/src/app.po.ts
❌ Failed -
apps/angular-demo/karma.conf.js
✅ Commit1abd3f9
-
apps/angular-demo/tsconfig.app.json
❌ Failed -
apps/angular-demo/tsconfig.spec.json
✅ Commit34177f5
-
apps/angular-demo/tsconfig.json
❌ Failed -
apps/angular-demo/package.json
❌ Failed -
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
-
apps/angular-demo/angular.json
❌ Failed -
apps/angular-demo/.browserslistrc
❌ Failed -
apps/angular-demo/.editorconfig
❌ Failed -
apps/angular-demo/.gitignore
✅ Commitbbcf4fa
- apps/angular-demo/CHANGELOG.md
- apps/angular-demo/README.md
sweep-aisweep-nightly
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededsweepAssigns Sweep to an issue or pull request.Assigns Sweep to an issue or pull request.