Skip to content

Commit 9520b6d

Browse files
committed
Fix get_generated_reports missing parameter
1 parent d90b060 commit 9520b6d

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

src/full_model/evaluate_full_model/evaluate_language_model.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -1178,6 +1178,7 @@ def evaluate_language_model(model, val_dl, tokenizer, writer, run_params, genera
11781178

11791179
# used in function get_generated_reports
11801180
sentence_tokenizer = spacy.load("en_core_web_trf")
1181+
bert_score = evaluate.load("bertscore")
11811182

11821183
with torch.no_grad():
11831184
for num_batch, batch in tqdm(enumerate(val_dl), total=NUM_BATCHES_TO_PROCESS_FOR_LANGUAGE_MODEL_EVALUATION):
@@ -1255,7 +1256,8 @@ def evaluate_language_model(model, val_dl, tokenizer, writer, run_params, genera
12551256
generated_sents_for_selected_regions,
12561257
selected_regions,
12571258
sentence_tokenizer,
1258-
BERTSCORE_SIMILARITY_THRESHOLD
1259+
BERTSCORE_SIMILARITY_THRESHOLD,
1260+
bert_score,
12591261
)
12601262

12611263
gen_and_ref_sentences["generated_sentences"].extend(generated_sents_for_selected_regions)

src/full_model/test_set_evaluation.py

+2-9
Original file line numberDiff line numberDiff line change
@@ -343,15 +343,8 @@ def iterate_over_test_loader(test_loader):
343343
generated_sents_for_selected_regions,
344344
selected_regions,
345345
sentence_tokenizer,
346-
BERTSCORE_SIMILARITY_THRESHOLD
347-
generated_reports, removed_similar_generated_sentences = (
348-
get_generated_reports(
349-
generated_sents_for_selected_regions,
350-
selected_regions,
351-
sentence_tokenizer,
352-
BERTSCORE_SIMILARITY_THRESHOLD,
353-
bert_score,
354-
)
346+
BERTSCORE_SIMILARITY_THRESHOLD,
347+
bert_score,
355348
)
356349

357350
gen_and_ref_sentences["generated_sentences"].extend(generated_sents_for_selected_regions)

0 commit comments

Comments
 (0)