Add support for *-wildcards in ignore-undeclared and ignore-unused
#479
+153
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherland
force-pushed
the
jherland/support-ignore-wildcards
branch
4 times, most recently
from
ec489ca to
0424cc3
Compare
jherland
force-pushed
the
jherland/support-ignore-wildcards
branch
from
0424cc3 to
cfd0735
Compare
Also document why this suffix is so special.
The '*' wildcards are translated into `.*` regular expression tokens (which match anything), and then passed to re.fullmatch(), which I believe should do exactly what we want in this case. That said, we need to take extra care to avoid injection of regexp special chars in the ignore patterns, so all other parts of the pattern are filtered through re.escape().
Add any package starting with "pytest-" to our default ignore_unused set. This should match pytest plugins that are commonly used together with pytest (also in our default ignore_unused set).
jherland
force-pushed
the
jherland/support-ignore-wildcards
branch
from
cfd0735 to
a6039c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478.
Allow
*-wildcards in values passed to theignore_undeclaredandignore_unusedsettings.The objective is to allow simple catch-all values, such as
pytest-*ortypes-*.One or more
*is allowed in each ignore-value. Each*will match zero of more characters of any kind. No other wildcard syntax (e.g. using?,[...]or{...}) is allowed at this point.Technically, each
*in an ignore string is replaced with.*and the resulting string is then interpreted as an RE pattern.This pattern is then matched against undeclared
importnames (in the case ofignore_undeclared) or unused package names (in the case ofignore_unused).Commits:
package: Preserve "-stubs" suffix in normalizationignore_{undeclared,unused}: Accept*-wildcards