Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bzlmod support for rules_haskell #1864

Closed
14 tasks done
ylecornec opened this issue Jan 30, 2023 · 5 comments
Closed
14 tasks done

Bzlmod support for rules_haskell #1864

ylecornec opened this issue Jan 30, 2023 · 5 comments
Assignees
Labels
P2 major: an upcoming release

Comments

@ylecornec
Copy link
Member

ylecornec commented Jan 30, 2023

Bzlmod is the new external dependency system for bazel and is not currently supported by rules_haskell.

@aherrmann
Copy link
Member

Similar to how we split rules_nixpkgs we would probably want to split out the rules_haskell rules_nixpkgs integration into its own module. (In the WORKSPACE world the nixpkgs integration is optional, but Bazel module does not support optional or conditional dependencies.)

@aherrmann aherrmann added the P2 major: an upcoming release label Feb 7, 2023
@ylecornec ylecornec removed their assignment Jun 30, 2023
@aherrmann aherrmann changed the title Bzlmod support Bzlmod support for rules_haskell Jul 18, 2023
@aherrmann
Copy link
Member

@avdv IIUC this is essentially done, correct? The only missing pieces are the docs generation and the buildifier on NixOS thing that are blocking this, correct? I've changed the status of this accordingly to "Blocked". Let me know if that's accurate or not.

@avdv
Copy link
Member

avdv commented Dec 14, 2023

IIUC this is essentially done, correct? The only missing pieces are the docs generation and the buildifier on NixOS thing that are blocking this, correct? I've changed the status of this accordingly to "Blocked". Let me know if that's accurate or not.

Correct, thank you!

@avdv
Copy link
Member

avdv commented Feb 21, 2024

Separated the remaining tasks which are blocked on upstream / new Bazel versions into their own issues. Closing.

@avdv avdv closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 major: an upcoming release
Projects
Development

No branches or pull requests

3 participants