Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select item right padding #9458

Closed
Bonapara opened this issue Jan 8, 2025 · 4 comments
Closed

Select item right padding #9458

Bonapara opened this issue Jan 8, 2025 · 4 comments
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Jan 8, 2025 •
edited
Loading

Current behavior

  • Tick is too close to the right edge
  • Is 14x14px
  • Icon is cropped - See how angles are not rounded. (because of width = 100% on left part - don't know why)

Image

Desired Behavior

  • Should be 16x16px
  • Icon shouldn't be cropped
  • Padding-right should be 8px

Image
@yadavshubham01
Copy link
Contributor

assign me

dev-kraken added a commit to dev-kraken/twenty that referenced this issue Jan 8, 2025
@dev-kraken
Fix twentyhq#9458: Add padding-right to IconCheck in MenuItemSelectAv…
9c4d0dc 
…atar
dev-kraken added a commit to dev-kraken/twenty that referenced this issue Jan 8, 2025
@dev-kraken
Fix twentyhq#9458: Replace hardcoded 8px with theme.spacing(2) in Sty…
d65f05f 
…ledIconCheck
dev-kraken added a commit to dev-kraken/twenty that referenced this issue Jan 9, 2025
@dev-kraken
Fix twentyhq#9458: Add padding-right to IconCheck in MenuItemSelectAv…
075e159 
…atar
dev-kraken added a commit to dev-kraken/twenty that referenced this issue Jan 9, 2025
@dev-kraken
Fix twentyhq#9458: Replace hardcoded 8px with theme.spacing(2) in Sty…
93233ce 
…ledIconCheck
@Bonapara Bonapara moved this from 🆕 New to 📋 Backlog in 🎯 Roadmap & Sprints Jan 10, 2025
@yadavshubham01
Copy link
Contributor

hey @Bonapara is issue open for work ??

@Bonapara
Copy link
Member Author

Yes @yadavshubham01!

@yadavshubham01
Copy link
Contributor

@Bonapara let me fix this issue

@yadavshubham01 yadavshubham01 mentioned this issue Jan 28, 2025
Merged
charlesBochet added a commit that referenced this issue Jan 28, 2025
@yadavshubham01 @charlesBochet
Fix Icon Padding and Size in Select Item (#9888)
8754b71 
This pull request addresses issue
[#9458](#9458) by making the
following changes:

Increase the icon size from 14x14px to 16x16px
Add 8px padding to the right side of the icon
Ensure the icon is not cropped and displays with rounded angles

---------

Co-authored-by: Charles Bochet <[email protected]>
charlesBochet added a commit that referenced this issue Jan 28, 2025
@yadavshubham01 @charlesBochet
Fix Icon Padding and Size in Select Item (#9888)
575b83c 
This pull request addresses issue
[#9458](#9458) by making the
following changes:

Increase the icon size from 14x14px to 16x16px
Add 8px padding to the right side of the icon
Ensure the icon is not cropped and displays with rounded angles

---------

Co-authored-by: Charles Bochet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
🎯 Roadmap & Sprints
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bonapara @yadavshubham01