fix(contact-form): two small mistakes (#342)

1. Front end: if a form submission fails due to a 500 error, the submit button previously stayed disabled. This adds a finally block to re-enable the button after everything else has happened.

2. Back end: two Twilio.Response objects were initialized when only one is needed.

Author: philnash

contact-form/assets/index.html

@@ -157,13 +157,14 @@ <h2>Contact form</h2>
             console.log(data);
             setStatus(data.error, "error");
           }
-          sendButton.removeAttribute("disabled");
         } catch (error) {
           setStatus(
             "There was an error and the message could not be sent. Sorry.",
             "error"
           );
           console.log(error);
+        } finally {
+          sendButton.removeAttribute("disabled");
         }
       });
     </script>

contact-form/functions/send-email.js

@@ -38,7 +38,6 @@ exports.handler = async function (context, event, callback) {
 
   try {
     await sg.send(msg);
-    const response = new Twilio.Response();
     response.setStatusCode(200);
     response.setBody({ success: true });
     return callback(null, response);