Skip to content

Conversation

@fastrde
Copy link

@fastrde fastrde commented Apr 26, 2020

See #163 for details.
Don't merge without further investigation!
It's the example how i solved this for my usecase.

if not self.connected:
raise LDAPServerConnectionLostException()
msg = pureldap.LDAPMessage(op, id=id)
msg = pureldap.LDAPMessage(op, controls=controls, id=id)
Copy link
Author

@fastrde fastrde Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controls=None is handled in pureldap so no need to handle it here. so just pass it.

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #171 into master will decrease coverage by 2.70%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   93.35%   90.64%   -2.71%     
==========================================
  Files          72       72              
  Lines        9914     9898      -16     
  Branches      972      974       +2     
==========================================
- Hits         9255     8972     -283     
- Misses        537      802     +265     
- Partials      122      124       +2     
Impacted Files Coverage Δ
ldaptor/protocols/ldap/proxybase.py 45.89% <50.00%> (-13.17%) ⬇️
ldaptor/testutil.py 85.84% <50.00%> (-6.61%) ⬇️
ldaptor/protocols/ldap/ldapserver.py 80.90% <77.77%> (+0.45%) ⬆️
ldaptor/protocols/ldap/ldapclient.py 89.20% <100.00%> (-2.58%) ⬇️
ldaptor/protocols/ldap/ldapsyntax.py 85.05% <100.00%> (-8.00%) ⬇️
ldaptor/protocols/ldap/merger.py 73.72% <100.00%> (-12.72%) ⬇️
ldaptor/protocols/ldap/proxy.py 83.33% <100.00%> (ø)
ldaptor/test/test_ldapclient.py 95.45% <100.00%> (-4.55%) ⬇️
ldaptor/numberalloc.py 51.35% <0.00%> (-43.25%) ⬇️
ldaptor/protocols/ldap/svcbindproxy.py 38.96% <0.00%> (-36.37%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bdfda...f294502. Read the comment docs.

@Ben-Ga
Copy link

Ben-Ga commented Dec 27, 2024

This also solved my issue where I was seeing this exception on my client app:

Caused by: com.unboundid.ldap.sdk.LDAPSearchException: size limit exceeded
        at com.unboundid.ldap.sdk.LDAPConnection.search(LDAPConnection.java:3994) ~[unboundid-ldapsdk-6.0.11.jar:6.0.11]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants