Skip to content

Commit 620f7ce

Browse files
authored
Deep sign TypeDB Driver and notarise Mac snapshots (#846)
## Usage and product changes - TypeDB Driver `.dylib` and `.jnilib` files will now be deep signed to ensure correct notarisation - We now perform code signing for Mac snapshots, to catch issues with it prior to release ## Implementation - Expand the `mac_deep_sign_jars_regex` - Add the required parameters when deploying mac snapshots
1 parent 627dc84 commit 620f7ce

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.circleci/config.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,13 @@ commands:
7373
# 2) jpackage does not support 0 as a major version
7474
# This writes VERSION-SHA1 into the VERSION file to be used by the assembly rule.
7575
echo $(cat VERSION)-$CIRCLE_SHA1 > VERSION
76-
bazel run //:deploy-mac-<<parameters.target-arch>>-dmg --compilation_mode=opt --spawn_strategy=local -- snapshot
76+
bazel run //:deploy-mac-<<parameters.target-arch>>-dmg --compilation_mode=opt \
77+
--define APPLE_CODE_SIGN=yes \
78+
--define APPLE_ID=$APPLE_ID \
79+
--define APPLE_ID_PASSWORD=$APPLE_ID_PASSWORD \
80+
--define APPLE_TEAM_ID=$APPLE_TEAM_ID \
81+
--define APPLE_CODE_SIGNING_CERT_PASSWORD=$APPLE_CODE_SIGNING_CERT_PASSWORD \
82+
--spawn_strategy=local -- snapshot
7783
7884
deploy-mac-release:
7985
parameters:

BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ assemble_jvm_platform(
176176
mac_app_id = "com.typedb.studio",
177177
mac_entitlements = "//config/mac:entitlements-mac-plist",
178178
mac_code_signing_cert = "@vaticle_apple_developer_id_application_cert//file",
179-
mac_deep_sign_jars_regex = ".*io-netty-netty.*",
179+
mac_deep_sign_jars_regex = ".*(io-netty-netty|typedb-typedb-driver).*",
180180
windows_menu_group = "TypeDB Studio",
181181
)
182182

0 commit comments

Comments
 (0)