Skip to content

Support for older pytest #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
delfick opened this issue May 2, 2024 · 6 comments · Fixed by #151
Closed

Support for older pytest #150

delfick opened this issue May 2, 2024 · 6 comments · Fixed by #151

Comments

@delfick
Copy link
Contributor

delfick commented May 2, 2024

Hi, I'm wondering how important it is to you for this plugin to continue supporting pytest 6?

Is pytest 7/8 are old enough to warrant removing the code that makes this plugin compatible with pytest 6 or would you rather keep that support?
@sobolevn
Copy link
Member

sobolevn commented May 3, 2024

pytest6 is not relevant anymore, we should not keep any support for it.
Cleaner code, simplier workflow.

@delfick
Copy link
Contributor Author

delfick commented May 3, 2024 via email

delfick added a commit to delfick/pytest-mypy-plugins that referenced this issue May 4, 2024
@delfick
Remove support for pytest 6.x
1133d30 
Pytest 7 was released over two years ago, and this repository no longer
tests against pytest 6. It should be safe to assume that projects aren't
relying on pytest 6 anymore.

fixes: typeddjango#150
@delfick delfick mentioned this issue May 4, 2024
Merged
sobolevn pushed a commit that referenced this issue May 4, 2024
@delfick
Remove support for pytest 6.x (#151)
bb643e6 
Pytest 7 was released over two years ago, and this repository no longer
tests against pytest 6. It should be safe to assume that projects aren't
relying on pytest 6 anymore.

fixes: #150
@delfick
Copy link
Contributor Author

delfick commented May 4, 2024

@sobolevn also, speaking of compatibility. Python 3.8 is end of life in later in the year, do you want to keep support for it till then, or is it ok to remove support for it and be able to use PEP 585 in this repo?

(Though, in finding that link I noticed that we can already make use of that with a from __future__ import annotations it seems)

@sobolevn
Copy link
Member

sobolevn commented May 4, 2024

Yes, we need 3.8 for now. django-stubs should drop it first.

@delfick
Copy link
Contributor Author

delfick commented May 4, 2024

ok, fair enough. The good news is it appears django 5 only supports python 3.10 and above, so I imagine django-stubs could maybe drop it soon?

@sobolevn
Copy link
Member

sobolevn commented May 4, 2024

yes, we will drop it as soon as it will reach EOL

griels pushed a commit to griels/pytest-mypy-plugins that referenced this issue Dec 19, 2024
@delfick
Remove support for pytest 6.x (typeddjango#151)
cc81bab 
Pytest 7 was released over two years ago, and this repository no longer
tests against pytest 6. It should be safe to assume that projects aren't
relying on pytest 6 anymore.

fixes: typeddjango#150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for pytest 6.x delfick/pytest-mypy-plugins
2 participants
@delfick @sobolevn