Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type parameter bounded by SAM might lead to false negative #6816

Open
theosotr opened this issue Sep 24, 2024 · 1 comment
Open

type parameter bounded by SAM might lead to false negative #6816

theosotr opened this issue Sep 24, 2024 · 1 comment

Comments

@theosotr
Copy link

Command

javac \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
  -J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED \
-processor org.checkerframework.checker.nullness.NullnessChecker \
-cp ~/projects/checker-framework/checker/dist/checker.jar -Aignorejdkastub Test.java

File

import java.util.function.*;
import org.checkerframework.checker.nullness.qual.*;

class A<T extends Function<Integer, Integer>> {
    T f;
    A(T f) {
        this.f = f;
    }
    T get() { return this.f; }
}

class Test {
    static public void main(String[] args) {
        new A<>(Test::m).get().apply(1).intValue();
    }

    public static <T extends @Nullable Object> T m(T x) { return (T) null; }
}

Actual behavior

There's a NPE at runtime

Exception in thread "main" java.lang.NullPointerException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "java.util.function.Function.apply(Object)" is null
        at Test.main(Test.java:14)

Expected behavior

The code should have been rejected.

@smillst
Copy link
Member

smillst commented Sep 24, 2024

Thanks for reporting this!

There is a missing cast warning here:

 return (T) null; 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants