Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Circuit breaker too aggressive during service restart #194

Open
Raynos opened this issue Dec 7, 2015 · 2 comments
Open

Circuit breaker too aggressive during service restart #194

Raynos opened this issue Dec 7, 2015 · 2 comments

Comments

@Raynos
Copy link
Contributor

Raynos commented Dec 7, 2015

If a service gets redeployed, it will stop and start a bunch of workers.

For each worker that's restarted it will ECONNRESET the socket and kill some inflight RPCs.

The circuit breaker immediately kicks in and things there is something wrong with the service.

We should ensure that we can do a rolling restart of all instances of a service without the circuit breaker penalizing all the caller.

cc: @kriskowal @jcorbin @rf

@blampe
Copy link
Contributor

blampe commented Dec 7, 2015

Wouldn't per-process circuits get around this? I think we had thrown that idea around before.

@Raynos
Copy link
Contributor Author

Raynos commented Dec 7, 2015

Even if we had per process circuits we still need to avoid triggering the per endpoint circuit.

We need per caller and per endpoint circuits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants