Apply explicit visibility on missing classes

Author: psteiger

android/libraries/rib-compiler-test/src/main/kotlin/com/uber/rib/compiler/Constants.kt

@@ -16,10 +16,10 @@
 package com.uber.rib.compiler
 
 /** Constant values used by the annotation processor. */
-open class Constants {
-  companion object {
-    const val INTERACTOR_TEST_CREATOR_PREFIX = "Test"
-    const val INTERACTOR_TEST_CREATOR_SUFFIX = "Interactor"
-    const val INTERACTOR_TEST_CREATOR_METHOD_NAME = "create"
+public open class Constants {
+  public companion object {
+    public const val INTERACTOR_TEST_CREATOR_PREFIX: String = "Test"
+    public const val INTERACTOR_TEST_CREATOR_SUFFIX: String = "Interactor"
+    public const val INTERACTOR_TEST_CREATOR_METHOD_NAME: String = "create"
   }
 }

android/libraries/rib-compiler-test/src/main/kotlin/com/uber/rib/compiler/InteractorTestGenerator.kt

@@ -33,7 +33,7 @@ import javax.lang.model.element.Modifier
  * @Scope
  * @Retention(SOURCE) public @interface LoggedInScope { } </code>
  */
-open class InteractorTestGenerator(
+public open class InteractorTestGenerator(
   processingEnvironment: ProcessingEnvironment,
   errorReporter: ErrorReporter,
 ) : Generator<InteractorAnnotatedClass>(processingEnvironment, errorReporter) {

android/libraries/rib-compiler-test/src/main/kotlin/com/uber/rib/compiler/RibTestProcessor.kt

@@ -23,7 +23,7 @@ import javax.annotation.processing.Processor
 
 /** Process the annotations for all added annotation processor pipelines. */
 @AutoService(Processor::class)
-open class RibTestProcessor : RibProcessor() {
+public open class RibTestProcessor : RibProcessor() {
   private var interactorTestGenerator: InteractorTestGenerator? = null
 
   @Synchronized

android/libraries/rib-workflow-test/src/main/kotlin/com/uber/rib/workflow/core/StepTester.kt

@@ -13,6 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+@file:Suppress("invisible_reference", "invisible_member")
+
 package com.uber.rib.workflow.core
 
 import com.google.common.base.Optional

android/tooling/rib-intellij-plugin/src/main/kotlin/com/uber/intellij/plugin/android/rib/AndroidDeviceRepository.kt

@@ -26,7 +26,7 @@ import org.jetbrains.android.sdk.AndroidSdkUtils
 
 /** IntelliJ Project component responsible for exposing connected Android devices. */
 @Service(PROJECT)
-class AndroidDeviceRepository(val project: Project) :
+public class AndroidDeviceRepository(public val project: Project) :
   AndroidDebugBridge.IDeviceChangeListener, Disposable {
 
   private val devices: ArrayList<IDevice> = arrayListOf()
@@ -60,15 +60,15 @@ class AndroidDeviceRepository(val project: Project) :
   }
 
   @Synchronized
-  fun addListener(listener: Listener) {
+  public fun addListener(listener: Listener) {
     listeners.add(listener)
     if (devices.size > 0) {
       listener.onAvailableDevicesChanged(devices)
     }
   }
 
   @Synchronized
-  fun removeListener(listener: Listener) {
+  public fun removeListener(listener: Listener) {
     if (listeners.contains(listener)) {
       listeners.remove(listener)
     }
@@ -79,7 +79,7 @@ class AndroidDeviceRepository(val project: Project) :
     listeners.forEach { it.onAvailableDevicesChanged(devices) }
   }
 
-  fun isBridgeConnected(): Boolean {
+  public fun isBridgeConnected(): Boolean {
     val debugBridge = AndroidDebugBridge.getBridge()
     return debugBridge != null && with(debugBridge) { isConnected && hasInitialDeviceList() }
   }
@@ -89,8 +89,8 @@ class AndroidDeviceRepository(val project: Project) :
     devices.clear()
   }
 
-  interface Listener {
+  public interface Listener {
 
-    fun onAvailableDevicesChanged(devices: List<IDevice>)
+    public fun onAvailableDevicesChanged(devices: List<IDevice>)
   }
 }

android/tooling/rib-intellij-plugin/src/main/kotlin/com/uber/intellij/plugin/android/rib/AttachRibProjectServiceActivity.kt

@@ -19,7 +19,7 @@ import com.intellij.openapi.components.service
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.StartupActivity
 
-class AttachRibProjectServiceActivity : StartupActivity.Background {
+public class AttachRibProjectServiceActivity : StartupActivity.Background {
   override fun runActivity(project: Project) {
     project.service<RibProjectService>().attach()
   }

android/tooling/rib-intellij-plugin/src/main/kotlin/com/uber/intellij/plugin/android/rib/CommandLineUtils.kt

@@ -26,7 +26,7 @@ import java.nio.charset.Charset
 import java.util.LinkedList
 
 /** Some command line utilities. */
-object CommandLineUtils {
+public object CommandLineUtils {
 
   /**
    * Executes `which` for a command.
@@ -38,7 +38,7 @@ object CommandLineUtils {
    * @throws ExecutionException
    * @throws IOException
    */
-  fun which(project: Project, command: String): String {
+  public fun which(project: Project, command: String): String {
     return executeWithLineOutput(project, "which", command).output()[0]
   }
 
@@ -53,7 +53,7 @@ object CommandLineUtils {
    * @throws ExecutionException
    * @throws IOException
    */
-  fun executeWithLineOutput(
+  public fun executeWithLineOutput(
     project: Project,
     command: String,
     vararg params: String,
@@ -93,15 +93,15 @@ object CommandLineUtils {
   }
 
   /** Holder for process output and error stream. */
-  class ProcessOutput(private val output: List<String>, private val error: List<String>) {
+  public class ProcessOutput(private val output: List<String>, private val error: List<String>) {
 
     /** Returns the process std output */
-    fun output(): List<String> {
+    public fun output(): List<String> {
       return output
     }
 
     /** Returns the process error output */
-    fun error(): List<String> {
+    public fun error(): List<String> {
       return error
     }
   }

android/tooling/rib-intellij-plugin/src/main/kotlin/com/uber/intellij/plugin/android/rib/RibHierarchyBrowser.kt

@@ -54,22 +54,22 @@ import javax.swing.tree.DefaultMutableTreeNode
 
 /** UI component used to render tree of Ribs. */
 @SuppressWarnings("TooManyFunctions")
-class RibHierarchyBrowser(
+public class RibHierarchyBrowser(
   project: Project,
   initialModel: Model,
   private val rootElement: PsiElement,
   private val selectionListener: Listener?,
 ) : HierarchyBrowserBase(project, rootElement) {
 
-  companion object {
+  public companion object {
     /** Go to previous Rib label */
-    const val LABEL_GO_PREVIOUS_RIB: String = "Go to previous Scope."
+    public const val LABEL_GO_PREVIOUS_RIB: String = "Go to previous Scope."
 
     /** Go to next Rib label */
-    const val LABEL_GO_NEXT_RIB: String = "Go to next Scope"
+    public const val LABEL_GO_NEXT_RIB: String = "Go to next Scope"
 
     /** Type of the Rib hierarchy */
-    const val TYPE_HIERARCHY_TYPE: String = "Ribs"
+    public const val TYPE_HIERARCHY_TYPE: String = "Ribs"
 
     private const val ENABLE_LOCATE_MODE: String = "Enable selecting RIB on device"
 
@@ -78,7 +78,7 @@ class RibHierarchyBrowser(
   }
 
   /** Enum used to represent the status of the component */
-  enum class Status {
+  public enum class Status {
     UNINITIALIZED,
     INITIALIZING,
     INITIALIZED,
@@ -92,7 +92,7 @@ class RibHierarchyBrowser(
    * @param selectedRibId the RIB ID of the RIB selected by user (if any)
    * @param selectedViewId the view ID of the view selected by user (if any)
    */
-  data class Model(
+  public data class Model(
     val host: RibHost,
     val selectedRibId: String = "",
     val selectedViewId: String = "",
@@ -214,7 +214,7 @@ class RibHierarchyBrowser(
   }
 
   /** Request to update hierarchy with provided model */
-  fun onModelUpdated(model: Model) {
+  public fun onModelUpdated(model: Model) {
     this.status = Status.INITIALIZED
     this.model = model
     this.refreshComplete = false
@@ -299,9 +299,9 @@ class RibHierarchyBrowser(
    * Interface used to notify that an new element was selected in {@ScopeHierarchyBrowser}
    * component.
    */
-  interface Listener {
+  public interface Listener {
 
     /** Callback indicating the selected Rib has changed. */
-    fun onSelectedRibChanged(id: UUID)
+    public fun onSelectedRibChanged(id: UUID)
   }
 }

android/tooling/rib-intellij-plugin/src/main/kotlin/com/uber/intellij/plugin/android/rib/RibHierarchyPanel.kt

@@ -38,14 +38,14 @@ import javax.swing.JSplitPane
 import javax.swing.JSplitPane.RIGHT
 
 /** UI Component representing the panel including rib hierarchy. */
-class RibHierarchyPanel(val project: Project, private val initialModel: Model) :
+public class RibHierarchyPanel(public val project: Project, private val initialModel: Model) :
   JPanel(),
   RibProjectService.Listener,
   ActionListener,
   RibHierarchyBrowser.Listener,
   RibViewBrowser.Listener {
 
-  companion object {
+  public companion object {
     private val EMPTY_RIB_VIEW: RibView = RibView("", "", "", "", emptyList())
     private val EMPTY_RIB_NODE: RibNode = RibNode("", "", emptyList(), EMPTY_RIB_VIEW)
     private val EMPTY_VIEW_MODEL: ViewModel =
@@ -113,13 +113,13 @@ class RibHierarchyPanel(val project: Project, private val initialModel: Model) :
   }
 
   /** Requests to update the list of devices. */
-  fun onAvailableDevicesChanged(devices: List<IDevice>) {
+  public fun onAvailableDevicesChanged(devices: List<IDevice>) {
     comboBoxModel.removeAllElements()
     devices.forEach { comboBoxModel.addElement(it) }
   }
 
   /** Requests to update the selected device. */
-  fun onSelectedDeviceChanged(selectedDevice: IDevice?) {
+  public fun onSelectedDeviceChanged(selectedDevice: IDevice?) {
     comboBoxModel.selectedItem = selectedDevice
   }
 

android/tooling/rib-intellij-plugin/src/main/kotlin/com/uber/intellij/plugin/android/rib/RibHierarchyUtils.kt

@@ -56,14 +56,14 @@ import java.util.UUID
 
 /** Utility class used by the Rib hierarchy browser component. */
 @SuppressWarnings("TooManyFunctions")
-class RibHierarchyUtils {
+public class RibHierarchyUtils {
 
   private constructor()
 
-  companion object {
+  public companion object {
 
     /** Constant used to represent empty UUID */
-    val EMPTY_UUID: UUID = UUID(0, 0)
+    public val EMPTY_UUID: UUID = UUID(0, 0)
 
     /** Time for balloon to fade out */
     private const val BALLOON_FADE_OUT_TIME: Long = 3000
@@ -72,7 +72,7 @@ class RibHierarchyUtils {
     private const val LAYOUT_FOLDER_NAME: String = "layout"
 
     /** Build root element, used when class is not available. */
-    fun buildRootElement(project: Project): PsiClass {
+    public fun buildRootElement(project: Project): PsiClass {
       val psiClass: PsiClass? =
         JavaPsiFacade.getInstance(project)
           .findClass(Object::class.java.name, GlobalSearchScope.allScope(project))
@@ -81,32 +81,32 @@ class RibHierarchyUtils {
     }
 
     /** Return the psiClass corresponding to the given class name. */
-    fun getPsiClass(project: Project, name: String): PsiClass {
+    public fun getPsiClass(project: Project, name: String): PsiClass {
       val psiClass: PsiClass? =
         JavaPsiFacade.getInstance(project).findClass(name, GlobalSearchScope.allScope(project))
       return psiClass ?: buildRootElement(project)
     }
 
     /** Check if the element supplied is a root element. */
-    fun isRootElement(element: PsiElement?): Boolean {
+    public fun isRootElement(element: PsiElement?): Boolean {
       return element is PsiClass && element.qualifiedName == Object::class.java.name
     }
 
     /** Format fully qualified class name. */
-    fun formatQualifiedName(qualifiedName: String): String {
+    public fun formatQualifiedName(qualifiedName: String): String {
       val index: Int = qualifiedName.lastIndexOf(".")
       return if (index > 0) qualifiedName.substring(0, index) else qualifiedName
     }
 
     /** Format fully qualified class name. */
-    fun formatSimpleName(qualifiedName: String): String {
+    public fun formatSimpleName(qualifiedName: String): String {
       val index: Int = qualifiedName.lastIndexOf(".")
       return if (index > 0) qualifiedName.substring(index + 1) else qualifiedName
     }
 
     /** Find node with the given ID in node hierarchy */
     @SuppressWarnings("ReturnCount")
-    fun findRibNodeRecursive(ribNode: RibNode?, id: UUID): RibNode? {
+    public fun findRibNodeRecursive(ribNode: RibNode?, id: UUID): RibNode? {
       if (ribNode == null) {
         return null
       }
@@ -124,7 +124,7 @@ class RibHierarchyUtils {
 
     /** Find view with the given ID in view hierarchy */
     @SuppressWarnings("ReturnCount")
-    fun findRibViewRecursive(ribView: RibView?, id: UUID): RibView? {
+    public fun findRibViewRecursive(ribView: RibView?, id: UUID): RibView? {
       if (ribView == null) {
         return null
       }
@@ -141,7 +141,7 @@ class RibHierarchyUtils {
     }
 
     /** Get a view tag value suffix */
-    fun getTagValueSuffix(value: String?): String? {
+    public fun getTagValueSuffix(value: String?): String? {
       if (value == null) {
         return null
       }
@@ -151,21 +151,21 @@ class RibHierarchyUtils {
 
     /** Get virtual file from path */
     @SuppressWarnings("MagicNumber")
-    fun getVirtualFile(filePath: String): VirtualFile? {
+    public fun getVirtualFile(filePath: String): VirtualFile? {
       val actualPath: Path = Paths.get(filePath)
       val pathFile: File = actualPath.toFile()
       return LocalFileSystem.getInstance().findFileByIoFile(pathFile)
     }
 
     /** Returns whether virtual file belongs to project and appears to be a layout file */
-    fun isProjectLayoutFile(project: Project, file: VirtualFile): Boolean {
+    public fun isProjectLayoutFile(project: Project, file: VirtualFile): Boolean {
       return ProjectRootManager.getInstance(project).fileIndex.isInContent(file) &&
         file.fileType is XmlFileType &&
         file.path.contains("/$LAYOUT_FOLDER_NAME/")
     }
 
     /** Display popup balloon. */
-    fun displayPopup(
+    public fun displayPopup(
       message: String,
       location: RelativePoint,
       type: MessageType = MessageType.WARNING,
@@ -178,7 +178,7 @@ class RibHierarchyUtils {
     }
 
     /** Display notification bubble. */
-    fun log(message: String) {
+    public fun log(message: String) {
       Notifications.Bus.notify(Notification("Rib", "Rib", message, NotificationType.INFORMATION))
     }
   }