Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinnamon-light theme colors issues. #3922

Closed
Initu-Castilhos opened this issue Jun 17, 2023 · 4 comments · Fixed by #3925
Closed

Cinnamon-light theme colors issues. #3922

Initu-Castilhos opened this issue Jun 17, 2023 · 4 comments · Fixed by #3925

Comments

@Initu-Castilhos
Copy link

In the light version, the separator and the corner bar are clear and the accent color is orange in all variants.
Captura de tela de 2023-06-17 12-53-04

It might be better to change the panel color to the titlebar color like Mint-Y's cinnamon theme.

@Jupi007
Copy link
Member

Jupi007 commented Jun 18, 2023

@hsbasu Can you look at the broken accent color generation, please?

@hsbasu
Copy link
Contributor

hsbasu commented Jun 18, 2023

@Jupi007 Sure.

@hsbasu
Copy link
Contributor

hsbasu commented Jun 18, 2023

I think we already discussed this in the following comment.

@Initu-Castilhos @Jupi007 I get it now. Those colours are coming from the sass files and are not using accent_bg_colour as their base. To modify those colours, the sass files need to be modified. I have cross checked all the colorizable assests are taking accent colour. I would suggest to have a separate commit for them.

Originally posted by @hsbasu in #3842 (comment)

We need to add them in the tweaks file. Unfortunately, I am too busy to create a PR this. And I am highly regretted for the inconvenience.

@Jupi007 Jupi007 linked a pull request Jun 25, 2023 that will close this issue
@Jupi007
Copy link
Member

Jupi007 commented Jun 25, 2023

Closed by #3925

@Jupi007 Jupi007 closed this as completed Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants