code improvements

Author: Matthias Opitz

block_news.php

@@ -48,7 +48,7 @@ public function specialization() {
      *
      * @return stdClass - the block content.
      */
-    public function get_content() : stdClass {
+    public function get_content(): stdClass {
         global $OUTPUT;
 
         if ($this->content !== null) {
@@ -82,7 +82,7 @@ public function get_content() : stdClass {
      *
      * @return array news items.
      */
-    public function fetch_news() : array {
+    public function fetch_news(): array {
         // Template data for mustache.
         $template = new stdClass();
 
@@ -144,7 +144,7 @@ public function fetch_news() : array {
      *
      * @return array of the pages where the block can be added.
      */
-    public function applicable_formats() : array {
+    public function applicable_formats(): array {
         return [
             'admin' => false,
             'site-index' => true,
@@ -159,7 +159,7 @@ public function applicable_formats() : array {
      *
      * @return bool.
      */
-    public function instance_allow_multiple() : bool {
+    public function instance_allow_multiple(): bool {
         return false;
     }
 
@@ -168,7 +168,7 @@ public function instance_allow_multiple() : bool {
      *
      * @return bool.
      */
-    public function has_config() : bool {
+    public function has_config(): bool {
         return true;
     }
 }

classes/admin_setting_date.php

@@ -45,7 +45,7 @@ public function __construct($name, $visiblename, $description, $defaultsetting)
      * @param string $query
      * @return string HMTL field
      */
-    public function output_html($data, $query='') : string {
+    public function output_html($data, $query=''): string {
         $default = $this->get_defaultsetting();
 
         return format_admin_setting($this, $this->visiblename,

classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

tests/behat/show_news.feature

@@ -26,4 +26,3 @@ Feature: Show news
     And I should see "News Title One"
     And I should see "News Title Two"
     And I should see "News Title Three"
-