From 2020e5b7bd47a1407afcb67cbda090382651a6a1 Mon Sep 17 00:00:00 2001 From: Jan Thurau Date: Mon, 7 Nov 2022 19:06:26 +0100 Subject: [PATCH] Fixes #436: Server crashes when webhook onConnect fails --- packages/extension-webhook/package.json | 1 + packages/extension-webhook/src/index.ts | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/extension-webhook/package.json b/packages/extension-webhook/package.json index 3063d2e30..fe0c89799 100644 --- a/packages/extension-webhook/package.json +++ b/packages/extension-webhook/package.json @@ -29,6 +29,7 @@ "dist" ], "dependencies": { + "@hocuspocus/common": "^1.0.0-beta.3", "@hocuspocus/server": "^1.0.0-beta.3", "@hocuspocus/transformer": "^1.0.0-beta.3", "axios": "^0.27.2" diff --git a/packages/extension-webhook/src/index.ts b/packages/extension-webhook/src/index.ts index 60f63d7af..141464093 100644 --- a/packages/extension-webhook/src/index.ts +++ b/packages/extension-webhook/src/index.ts @@ -9,6 +9,7 @@ import { import { Doc } from 'yjs' import { TiptapTransformer, Transformer } from '@hocuspocus/transformer' import axios, { AxiosResponse } from 'axios' +import { Forbidden } from '@hocuspocus/common' export enum Events { onChange = 'change', @@ -175,8 +176,8 @@ export class Webhook implements Extension { ? JSON.parse(response.data) : response.data } catch (e) { - // eslint-disable-next-line no-throw-literal - throw null + console.error(`Caught error in extension-webhook: ${e}`) + throw Forbidden } }