Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in direct connection #846

Open
yurtsiv opened this issue Jul 17, 2024 · 0 comments
Open

Memory leak in direct connection #846

yurtsiv opened this issue Jul 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yurtsiv
Copy link

yurtsiv commented Jul 17, 2024

Description

The document is not unloaded after invoking DirectConnection.disconnect() if one of store document hooks fails.
The most common scenario is Redis extension failing to acquire the lock.

Scenario

Server A opens/closes many direct connections to documents without any other connections on that server. However, some of those documents might be loaded and updated on server B, occasionally causing the aforementioned lock error. As a result server A slowly accumulates loaded documents.

As a workaround, I'm periodically unloading documents without connections, but I believe the issue should be addressed in Hocuspocus.

Perhaps unloading should occur regardless of store document hook result?

Environment?

  • Hocuspocus version: 2.13.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants