Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: After selecting multiple rows or columns in the table,attribute[form & to] in [editor.state.selection] are only last tabelcell's attribute[form & to]. Function toggleList use selection need fix #5737

Open
1 task done
ZhaoJianXXXXX opened this issue Oct 17, 2024 · 1 comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@ZhaoJianXXXXX
Copy link

Affected Packages

core

Version(s)

2.8.0

Bug Description

For example, batch settings bulletList by toggelist, in Table

_CellSelection: {
ranges:[
SelectionRange: { $from: { pos: 248 }, $to: {p os: 258 } },
SelectionRange: { $from: { pos: 236 }, $to: {p os: 246 } },
],
$from: { pos: 248 },
$to: { pos: 258 },
from: 248,
to: 258
}

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

expect [from 236 to 258] or [258 to 236]

Additional Context (Optional)

No response

Dependency Updates

  • Yes, I've updated all my dependencies.
@ZhaoJianXXXXX ZhaoJianXXXXX added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Oct 17, 2024
@ZhaoJianXXXXX
Copy link
Author

setMark: const { empty, ranges } = selection & ranges.forEach
toggleList: const { $from, $to } = selection

so except toggleList use ranges rather than from&to

@ZhaoJianXXXXX ZhaoJianXXXXX changed the title [Bug]: After selecting multiple rows or columns in the table,attribute[form & to] in [editor.state.selection] are only last tabelcell's attribute[form & to]. The style can only be set to the last cell [Bug]: After selecting multiple rows or columns in the table,attribute[form & to] in [editor.state.selection] are only last tabelcell's attribute[form & to]. Function toggleList use selection need fix Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

1 participant