Added js-check.

uhop · uhop · commit 28730feadc58 · 2026-05-07T14:23:58.000-05:00
diff --git a/.clinerules b/.clinerules
@@ -1,4 +1,3 @@
-<!-- Canonical source: AGENTS.md — keep this file in sync -->
 # time-queues — AI Agent Rules
 
 ## Project identity
@@ -11,7 +10,7 @@ For detailed usage docs and API references see the [wiki](https://github.com/uho
 ## Setup
 
 ```bash
-git clone --recurse-submodules git@github.com:uhop/time-queues.git
+git clone --recurse-submodules https://github.com/uhop/time-queues.git
 cd time-queues
 npm install
 ```
@@ -23,6 +22,7 @@ npm install
 - `npm run test:bun` — run with Bun
 - `npm run test:deno` — run with Deno
 - `npm run ts-check` — TypeScript type checking (tsc --noEmit)
+- `npm run js-check` — JS lint via TypeScript (`tsconfig.check.json`: unused vars / undeclared refs / missing returns / unreachable code)
 - `npm run ts-test` — run TS typing tests
 - `npm run lint` — Prettier format check
 - `npm run lint:fix` — Prettier auto-format
diff --git a/.cursorrules b/.cursorrules
@@ -1,4 +1,3 @@
-<!-- Canonical source: AGENTS.md — keep this file in sync -->
 # time-queues — AI Agent Rules
 
 ## Project identity
@@ -11,7 +10,7 @@ For detailed usage docs and API references see the [wiki](https://github.com/uho
 ## Setup
 
 ```bash
-git clone --recurse-submodules git@github.com:uhop/time-queues.git
+git clone --recurse-submodules https://github.com/uhop/time-queues.git
 cd time-queues
 npm install
 ```
@@ -23,6 +22,7 @@ npm install
 - `npm run test:bun` — run with Bun
 - `npm run test:deno` — run with Deno
 - `npm run ts-check` — TypeScript type checking (tsc --noEmit)
+- `npm run js-check` — JS lint via TypeScript (`tsconfig.check.json`: unused vars / undeclared refs / missing returns / unreachable code)
 - `npm run ts-test` — run TS typing tests
 - `npm run lint` — Prettier format check
 - `npm run lint:fix` — Prettier auto-format
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -31,3 +31,4 @@ jobs:
           npm ci
           npm test
           npm run ts-check --if-present
+          npm run js-check --if-present
diff --git a/.windsurfrules b/.windsurfrules
@@ -1,4 +1,3 @@
-<!-- Canonical source: AGENTS.md — keep this file in sync -->
 # time-queues — AI Agent Rules
 
 ## Project identity
@@ -11,7 +10,7 @@ For detailed usage docs and API references see the [wiki](https://github.com/uho
 ## Setup
 
 ```bash
-git clone --recurse-submodules git@github.com:uhop/time-queues.git
+git clone --recurse-submodules https://github.com/uhop/time-queues.git
 cd time-queues
 npm install
 ```
@@ -23,6 +22,7 @@ npm install
 - `npm run test:bun` — run with Bun
 - `npm run test:deno` — run with Deno
 - `npm run ts-check` — TypeScript type checking (tsc --noEmit)
+- `npm run js-check` — JS lint via TypeScript (`tsconfig.check.json`: unused vars / undeclared refs / missing returns / unreachable code)
 - `npm run ts-test` — run TS typing tests
 - `npm run lint` — Prettier format check
 - `npm run lint:fix` — Prettier auto-format
diff --git a/AGENTS.md b/AGENTS.md
@@ -22,6 +22,7 @@ npm install
 - `npm run test:bun` — run with Bun
 - `npm run test:deno` — run with Deno
 - `npm run ts-check` — TypeScript type checking (tsc --noEmit)
+- `npm run js-check` — JS lint via TypeScript (`tsconfig.check.json`: unused vars / undeclared refs / missing returns / unreachable code)
 - `npm run ts-test` — run TS typing tests
 - `npm run lint` — Prettier format check
 - `npm run lint:fix` — Prettier auto-format
diff --git a/package.json b/package.json
@@ -18,6 +18,7 @@
     "test:seq:bun": "bun run `tape6-seq --self` --flags FO",
     "test:seq:deno": "deno run -A `tape6-seq --self` --flags FO",
     "ts-check": "tsc --noEmit",
+    "js-check": "tsc --project tsconfig.check.json",
     "ts-test": "tape6 --flags FO '/ts-tests/test-*.*ts'",
     "ts-test:bun": "tape6-bun --flags FO '/ts-tests/test-*.*ts'",
     "ts-test:deno": "tape6-deno --flags FO '/ts-tests/test-*.*ts'",
diff --git a/src/ListQueue.d.ts b/src/ListQueue.d.ts
@@ -1,3 +1,4 @@
+import List from 'list-toolkit/list.js';
 import {MicroTask} from './MicroTask.js';
 import {MicroTaskQueue} from './MicroTaskQueue.js';
 
@@ -11,6 +12,11 @@ export declare class ListQueue extends MicroTaskQueue {
    */
   paused: boolean;
 
+  /**
+   * The linked list of pending microtasks.
+   */
+  list: List<MicroTask>;
+
   /**
    * The function that stops the queue.
    * It is used internally by `pause()` and `resume()`.
diff --git a/src/ListQueue.js b/src/ListQueue.js
@@ -1,12 +1,14 @@
 // @ts-self-types="./ListQueue.d.ts"
 
 import List from 'list-toolkit/list.js';
+import MicroTask from './MicroTask.js';
 import MicroTaskQueue from './MicroTaskQueue.js';
 
 export class ListQueue extends MicroTaskQueue {
   constructor(paused) {
     super(paused);
     // AI-NOTE: Using list-toolkit List for O(1) push/pop operations
+    /** @type {List<MicroTask>} */
     this.list = new List();
     // AI-NOTE: stopQueue holds the stop function returned by startQueue(), or null
     this.stopQueue = null;
diff --git a/src/MicroTaskQueue.js b/src/MicroTaskQueue.js
@@ -19,7 +19,7 @@ export class MicroTaskQueue {
     this.paused = false;
     return this;
   }
-  enqueue(fn) {
+  enqueue(fn, ..._args) {
     const task = new MicroTask(fn);
     return task;
   }
diff --git a/src/PageWatcher.js b/src/PageWatcher.js
@@ -44,7 +44,8 @@ export class PageWatcher extends ListQueue {
 
   // Implemented in ListQueue: dequeue()
 
-  schedule() {
+  /** @returns {never} */
+  schedule(_fn) {
     throw new Error('Not implemented');
   }
 
diff --git a/src/Scheduler.d.ts b/src/Scheduler.d.ts
@@ -1,3 +1,4 @@
+import MinHeap from 'list-toolkit/heap.js';
 import MicroTask from './MicroTask.js';
 import MicroTaskQueue from './MicroTaskQueue.js';
 
@@ -71,6 +72,17 @@ export declare class Scheduler extends MicroTaskQueue {
    */
   paused: boolean;
 
+  /**
+   * The min-heap of pending tasks ordered by `time`.
+   */
+  queue: MinHeap<Task>;
+
+  /**
+   * The function that stops the scheduler loop.
+   * It is used internally by `pause()` and `resume()`.
+   */
+  stopQueue: (() => void) | null;
+
   /**
    * The tolerance for comparing starting times of tasks.
    * This allows for small timing differences in task execution.
diff --git a/src/Scheduler.js b/src/Scheduler.js
@@ -20,7 +20,9 @@ export class Task extends MicroTask {
 export class Scheduler extends MicroTaskQueue {
   constructor(paused, tolerance = 4) {
     super(paused);
-    this.queue = new MinHeap({less: (a, b) => a.time < b.time});
+    /** @type {(a: Task, b: Task) => boolean} */
+    const less = (a, b) => a.time < b.time;
+    this.queue = new MinHeap({less});
     this.tolerance = tolerance;
     this.stopQueue = null;
   }
diff --git a/src/defer.js b/src/defer.js
@@ -1,5 +1,6 @@
 // @ts-self-types="./defer.d.ts"
 
+/** @type {(...args: any[]) => any} */
 let deferImplementation = setTimeout;
 
 if (typeof requestIdleCallback == 'function') {
diff --git a/src/when-dom-loaded.js b/src/when-dom-loaded.js
@@ -2,10 +2,11 @@
 
 import ValueList from 'list-toolkit/value-list.js';
 
+/** @type {ValueList<() => void>} */
 const waitingForDom = new ValueList();
 
 export const remove = fn => {
-  for (const node of waitingForDom.getNodeIterable()) {
+  for (const node of waitingForDom.getNodeIterator()) {
     if (node.value === fn) {
       waitingForDom.removeNode(node);
       return true;
diff --git a/src/when-loaded.js b/src/when-loaded.js
@@ -2,10 +2,11 @@
 
 import ValueList from 'list-toolkit/value-list.js';
 
+/** @type {ValueList<() => void>} */
 const waitingForLoad = new ValueList();
 
 export const remove = fn => {
-  for (const node of waitingForLoad.getNodeIterable()) {
+  for (const node of waitingForLoad.getNodeIterator()) {
     if (node.value === fn) {
       waitingForLoad.removeNode(node);
       return true;
diff --git a/tsconfig.check.json b/tsconfig.check.json
@@ -0,0 +1,22 @@
+{
+  "include": ["src/**/*.js"],
+  "compilerOptions": {
+    "target": "ES2022",
+    "lib": ["ES2024", "DOM"],
+    "module": "Node16",
+    "moduleResolution": "Node16",
+    "noEmit": true,
+    "allowJs": true,
+    "checkJs": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noImplicitReturns": true,
+    "allowUnreachableCode": false,
+    "allowUnusedLabels": false,
+    "strict": false,
+    "skipLibCheck": true,
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "types": ["node"]
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ export class MicroTaskQueue {`
`19`	`19`	`this.paused = false;`
`20`	`20`	`return this;`
`21`	`21`	`}`
`22`		`- enqueue(fn) {`
	`22`	`+ enqueue(fn, ..._args) {`
`23`	`23`	`const task = new MicroTask(fn);`
`24`	`24`	`return task;`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ export class PageWatcher extends ListQueue {`
`44`	`44`
`45`	`45`	`// Implemented in ListQueue: dequeue()`
`46`	`46`
`47`		`- schedule() {`
	`47`	`+ /** @returns {never} */`
	`48`	`+ schedule(_fn) {`
`48`	`49`	`throw new Error('Not implemented');`
`49`	`50`	`}`
`50`	`51`