Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPLD Player v1.0.0 UI #5

Open
2 of 4 tasks
Tracked by #3
SuaYoo opened this issue Apr 28, 2022 · 3 comments
Open
2 of 4 tasks
Tracked by #3

NPLD Player v1.0.0 UI #5

SuaYoo opened this issue Apr 28, 2022 · 3 comments
Assignees
@SuaYoo

Comments

@SuaYoo
Copy link
Contributor

SuaYoo commented Apr 28, 2022 •
edited
Loading

  • Set up electron app in dev Setup Electron app #6
  • Present a simple browser UI: Home, Forward, Back, Address Bar, Reload/Stop, Zoom In/Out, Print
  • Keyboard shortcuts
  • Prod build
@SuaYoo SuaYoo mentioned this issue Apr 28, 2022
Open
14 tasks
@SuaYoo SuaYoo changed the title Present a simple browser UI: Home, Forward, Back, Address Bar, Reload/Stop, Zoom In/Out, Print (if enabled. Present a simple browser UI Apr 28, 2022
@SuaYoo SuaYoo changed the title Present a simple browser UI NPLD Player v1.0.0 UI Apr 28, 2022
@SuaYoo SuaYoo mentioned this issue Apr 28, 2022
Merged
SuaYoo added a commit that referenced this issue Apr 28, 2022
@SuaYoo
Setup Electron app (#6)
4d9a5c9 
#5
@SuaYoo SuaYoo self-assigned this Apr 28, 2022
@SuaYoo SuaYoo mentioned this issue May 1, 2022
Merged
SuaYoo added a commit that referenced this issue May 1, 2022
@SuaYoo
Setup UI library and JS renderer (#8)
a017c15 
#5
@SuaYoo SuaYoo mentioned this issue May 1, 2022
Merged
SuaYoo added a commit that referenced this issue May 3, 2022
@SuaYoo
Refactor to use lit (#9)
5b307bc 
#5
@SuaYoo SuaYoo mentioned this issue May 3, 2022
Merged
SuaYoo added a commit that referenced this issue May 7, 2022
@SuaYoo
Webview - Visit initial web address, go back, forward, home (#10)
836d89a 
#7 
#5
@SuaYoo SuaYoo mentioned this issue May 12, 2022
Merged
@anjackson
Copy link
Contributor

Any accessibility concerns?

@anjackson
Copy link
Contributor

Hi @SuaYoo @ikreymer I've been experimenting with and tweaking the build, and I noticed that if I press print, the console logs:

TODO printPage

Are you able to finish off this work?

@ikreymer
Copy link
Contributor

ikreymer commented Mar 6, 2023

Hi @SuaYoo @ikreymer I've been experimenting with and tweaking the build, and I noticed that if I press print, the console logs:

TODO printPage

Are you able to finish off this work?

Yes, sorry about that, will look into wrapping this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anjackson @ikreymer @SuaYoo