Preset property value: acceptance test #21498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

NguyenThuyLan wants to merge 20 commits into main from v17/QA/preset-property-value

build/nightly-E2E-build-template.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -54,11 +54,17 @@ steps: @@
       - pwsh: |
           $sourcePath = "$(Build.SourcesDirectory)/tests/Umbraco.Tests.AcceptanceTest/tests/${{ parameters.testFolder }}/AdditionalSetup"
           $destinationPath = "UmbracoProject"
-          $csharpFiles = Get-ChildItem -Path $sourcePath -Filter "*.cs"
+          $csharpFiles = Get-ChildItem -Path $sourcePath -Filter "*.cs" -Recurse
           if ($csharpFiles) {
             $csharpFiles | ForEach-Object {
-              Write-Host "Copying: $($_.FullName)"
-              Copy-Item -Path $_.FullName -Destination $destinationPath -Force
+              $relativePath = $_.FullName.Substring($sourcePath.Length + 1)
+              $targetPath = Join-Path -Path $destinationPath -ChildPath $relativePath
+              $targetDir = Split-Path -Path $targetPath -Parent
+              if (-not (Test-Path -Path $targetDir)) {
+                New-Item -ItemType Directory -Path $targetDir -Force | Out-Null
+              }
+              Write-Host "Copying: $($_.FullName) -> $targetPath"
+              Copy-Item -Path $_.FullName -Destination $targetPath -Force
             }
           } else {
             Write-Host "No C# files found."
@@ Expand Down @@

...ionRegistry/AdditionalSetup/App_Plugins/property-preset-value/preset-value-no-property.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

...egistry/AdditionalSetup/App_Plugins/property-preset-value/preset-value-no-property.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

...onRegistry/AdditionalSetup/App_Plugins/property-preset-value/preset-value-schema-alias.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

...gistry/AdditionalSetup/App_Plugins/property-preset-value/preset-value-schema-alias.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

...ensionRegistry/AdditionalSetup/App_Plugins/property-preset-value/property-preset-value.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

...onRegistry/AdditionalSetup/App_Plugins/property-preset-value/property-preset-value.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

.../ExtensionRegistry/AdditionalSetup/App_Plugins/property-preset-value/umbraco-package.json

-Original file line number
+Diff line change
@@ -0,0 +1,26 @@
+    {
+      "name": "Preset Text Value",
+      "version": "1.0.0",
+      "extensions": [
+        {
+          "type": "propertyValuePreset",
+          "alias": "presettextvalue",
+          "name": "Preset Text Value",
+          "api": "/App_Plugins/property-preset-value/property-preset-value.js",
+          "forPropertyEditorUiAlias": "Umb.PropertyEditorUi.TextBox"
+        },
+        {
+          "type": "propertyValuePreset",
+          "alias": "presetvalueforpropertyschema",
+          "name": "Preset Value for Property Schema alias",
+          "api": "/App_Plugins/property-preset-value/preset-value-schema-alias.js",
+          "forPropertyEditorSchemaAlias": "Umbraco.TextArea"
+        },
+        {
+          "type": "propertyValuePreset",
+          "alias": "presetvaluefornopropertyeditor",
+          "name": "Preset Value for No Property Editor",
+          "api": "/App_Plugins/property-preset-value/preset-value-no-property.js"
+        }
+      ]
+    }

...Tests.AcceptanceTest/tests/ExtensionRegistry/AdditionalSetup/Segments/MySegmentService.cs

-Original file line number
+Diff line change
@@ -0,0 +1,36 @@
+    using Umbraco.Cms.Core;
+    using Umbraco.Cms.Core.Composing;
+    using Umbraco.Cms.Core.Configuration.Models;
+    using Umbraco.Cms.Core.Models;
+    using Umbraco.Cms.Core.Services;
+    using Umbraco.Cms.Core.Services.OperationStatus;
+    public class MySegmentService : ISegmentService
+    {
+        // define a collection of segments to use
+        private readonly Segment[] _segments =
+        [
+            new Segment { Alias = "vip-members", Name = "VIP members" }
+        ];
+        public Task<Attempt<PagedModel<Segment>?, SegmentOperationStatus>> GetPagedSegmentsAsync(int skip = 0, int take = 100) => Task.FromResult
+        (
+            Attempt.SucceedWithStatus<PagedModel<Segment>?, SegmentOperationStatus>
+            (
+                SegmentOperationStatus.Success,
+                new PagedModel<Segment> { Total = _segments.Length, Items = _segments.Skip(skip).Take(take) }
+            )
+        );
+    }
+    public class MySegmentComposer : IComposer
+    {
+        public void Compose(IUmbracoBuilder builder)
+        {
+            // register the custom segment service in place of the Umbraco core implementation
+            builder.Services.AddUnique<ISegmentService, MySegmentService>();
+            // update segment configuration so segments are enabled (in the client)
+            builder.Services.Configure<SegmentSettings>(settings => settings.Enabled = true);
+        }
+    }

tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyPresetValue.spec.ts

-Original file line number
+Diff line change
@@ -0,0 +1,137 @@
+    import {ConstantHelper, test} from '@umbraco/playwright-testhelpers';
+    import {expect} from "@playwright/test";
+    // Content
+    const contentName = 'TestContent';
+    const secondContentName = 'Test indhold';
+    const textContent = 'Some text content';
+    // DocumentType
+    const documentTypeName = 'TestDocumentTypeForContent';
+    // DataType
+    const dataTypeName = 'Textstring';
+    const textAreaDataTypeName = 'Textarea';
+    // Initial Preset Value
+    const initialPresetValue = 'Preset value';
+    const initialVariantPresetValue = 'Preset value varies by culture:';
+    const varyBySegmentText = ' varies by segment:';
+    const initialAreaPresetValue = 'Preset value for property editor schema alias';
+    // Second language
+    const secondLanguageName = 'Danish';
+    // Segments
+    const vipMemberSegment = 'VIP members';
+    const vipMemberSegmentAlias = 'vip-members';
+    test.afterEach(async ({ umbracoApi }) => {
+        await umbracoApi.document.ensureNameNotExists(contentName);
+        await umbracoApi.document.ensureNameNotExists(secondContentName);
+        await umbracoApi.document.ensureNameNotExists(vipMemberSegment);
+        await umbracoApi.documentType.ensureNameNotExists(documentTypeName);
+        await umbracoApi.language.ensureNameNotExists(secondLanguageName);
+    });
+    test('can insert specific preset values into text box and text area properties', async ({umbracoApi, umbracoUi}) => {
+      // Arrange
+      const dataTypeData = await umbracoApi.dataType.getByName(dataTypeName);
+      const areaDataType = await umbracoApi.dataType.getByName(textAreaDataTypeName);
+      await umbracoApi.documentType.createDocumentTypeWithTwoPropertyEditors(documentTypeName, dataTypeName, dataTypeData.id, textAreaDataTypeName, areaDataType.id, 'test group');
+      await umbracoUi.goToBackOffice();
+      await umbracoUi.content.goToSection(ConstantHelper.sections.content);
+      // Act
+      await umbracoUi.content.clickActionsMenuAtRoot();
+      await umbracoUi.content.clickCreateActionMenuOption();
+      await umbracoUi.content.chooseDocumentType(documentTypeName);
+      await umbracoUi.content.enterContentName(contentName);
+      // Assert
+      await umbracoUi.content.doesTextStringHaveExpectedValue(initialPresetValue);
+      await umbracoUi.content.doesTextAreaHaveExpectedValue(initialAreaPresetValue);
+      await umbracoUi.content.clickSaveButtonAndWaitForContentToBeCreated();
+      expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy();
+      const contentData = await umbracoApi.document.getByName(contentName);
+      expect(contentData.values.find(item => item.editorAlias === dataTypeData.editorAlias).value).toBe(initialPresetValue);
+      expect(contentData.values.find(item => item.editorAlias === areaDataType.editorAlias).value).toBe(initialAreaPresetValue);
+    });
+    test('can insert preset value into textstring property that vary by culture in second language', async ({umbracoApi, umbracoUi}) => {
+      test.slow();
+      // Arrange
+      const languageId = await umbracoApi.language.createDanishLanguage();
+      const languageData = await umbracoApi.language.get(languageId);
+      const variantPresetValue = initialVariantPresetValue + ' ' + languageData.isoCode;
+      const dataTypeData = await umbracoApi.dataType.getByName(dataTypeName);
+      const documentTypeId = await umbracoApi.documentType.createDocumentTypeWithPropertyEditor(documentTypeName, dataTypeName, dataTypeData.id, 'Test group', true, true);
+      await umbracoApi.document.createDocumentWithEnglishCultureAndTextContent(contentName, documentTypeId, textContent, dataTypeName, true);
+      await umbracoUi.goToBackOffice();
+      await umbracoUi.content.goToSection(ConstantHelper.sections.content);
+      // Act
+      await umbracoUi.content.goToContentWithName(contentName);
+      await umbracoUi.content.clickSelectVariantButton();
+      await umbracoUi.content.clickVariantAddModeButtonForLanguageName(secondLanguageName);
+      await umbracoUi.content.enterContentName(secondContentName);
+      // Assert
+      await umbracoUi.content.doesTextStringHaveExpectedValue(variantPresetValue);
+      await umbracoUi.content.clickSaveButtonForContent();
+      await umbracoUi.waitForTimeout(ConstantHelper.wait.short);
+      await umbracoUi.content.clickSaveModalButtonAndWaitForContentToBeUpdated();
+      await umbracoUi.waitForTimeout(ConstantHelper.wait.short);
+      expect(await umbracoApi.document.doesNameExist(secondContentName)).toBeTruthy();
+      const contentData = await umbracoApi.document.getByName(secondContentName);
+      expect(contentData.values.find(item=>item.culture === languageData.isoCode).value).toBe(variantPresetValue);
+    });
+    test('can insert preset value into textstring property that shared across segments in content that is enabled vary by segment', async ({umbracoApi, umbracoUi}) => {
+      // Arrange
+      const dataTypeData = await umbracoApi.dataType.getByName(dataTypeName);
+      const documentTypeVaryByCulture = false;
+      const propertyVaryByCulture = false;
+      const documentTypeVaryBySegment = true;
+      const propertyVaryBySegment = false;
+      await umbracoApi.documentType.createDocumentTypeWithPropertyEditor(documentTypeName, dataTypeName, dataTypeData.id, 'Test group', documentTypeVaryByCulture, propertyVaryByCulture, false, documentTypeVaryBySegment, propertyVaryBySegment);
+      await umbracoUi.goToBackOffice();
+      await umbracoUi.content.goToSection(ConstantHelper.sections.content);
+      // Act
+      await umbracoUi.content.clickActionsMenuAtRoot();
+      await umbracoUi.content.clickCreateActionMenuOption();
+      await umbracoUi.content.chooseDocumentType(documentTypeName);
+      await umbracoUi.content.enterContentName(contentName);
+      await umbracoUi.content.clickSaveButtonAndWaitForContentToBeCreated();
+      await umbracoUi.waitForTimeout(ConstantHelper.wait.short);
+      await umbracoUi.content.clickSelectVariantButton();
+      await umbracoUi.content.clickVariantAddModeButtonForLanguageName(vipMemberSegment);
+      await umbracoUi.content.clickSaveButtonAndWaitForContentToBeUpdated();
+      // Assert
+      await umbracoUi.content.doesTextStringHaveExpectedValue(initialPresetValue);
+    });
+    test('can insert preset value in textstring property that vary by segment in content that is enabled vary by segment', async ({umbracoApi, umbracoUi}) => {
+      // Arrange
+      const dataTypeData = await umbracoApi.dataType.getByName(dataTypeName);
+      const documentTypeVaryByCulture = false;
+      const propertyVaryByCulture = false;
+      const documentTypeVaryBySegment = true;
+      const propertyVaryBySegment = true;
+      const expectedString = initialPresetValue + varyBySegmentText + ' ' + vipMemberSegmentAlias;
+      await umbracoApi.documentType.createDocumentTypeWithPropertyEditor(documentTypeName, dataTypeName, dataTypeData.id, 'Test group', documentTypeVaryByCulture, propertyVaryByCulture, false, documentTypeVaryBySegment, propertyVaryBySegment);
+      await umbracoUi.goToBackOffice();
+      await umbracoUi.content.goToSection(ConstantHelper.sections.content);
+      // Act
+      await umbracoUi.content.clickActionsMenuAtRoot();
+      await umbracoUi.content.clickCreateActionMenuOption();
+      await umbracoUi.content.chooseDocumentType(documentTypeName);
+      await umbracoUi.content.enterContentName(contentName);
+      await umbracoUi.content.clickSaveButtonAndWaitForContentToBeCreated();
+      await umbracoUi.waitForTimeout(ConstantHelper.wait.short);
+      await umbracoUi.content.clickSelectVariantButton();
+      await umbracoUi.content.clickVariantAddModeButtonForLanguageName(vipMemberSegment);
+      // Assert
+      await umbracoUi.content.doesTextStringHaveExpectedValue(expectedString);
+      await umbracoUi.content.clickSaveButtonAndWaitForContentToBeUpdated();
+      const contentData = await umbracoApi.document.getByName(contentName);
+      expect(contentData.values.find(item => item.segment === vipMemberSegmentAlias).value).toBe(expectedString);
+    });

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preset property value: acceptance test #21498

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Preset property value: acceptance test #21498

Are you sure you want to change the base?

Uh oh!

Preset property value: acceptance test #21498

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!