Skip to content

Open two methods of UmbracoDatabaseFactory for External Packages (closes #21606) #21589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idseefeld wants to merge 24 commits into
base: main
Choose a base branch
from
+2 −2
Open

Open two methods of UmbracoDatabaseFactory for External Packages (closes #21606) #21589

Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
028b07f
quote table, column and alias names with SqlSyntaxProvider methods in…
idseefeld Jan 29, 2026
e406c32
refactoring private methods into new file as internal methods,
idseefeld Jan 29, 2026
8344bfb
refactor GetAlias method
idseefeld Jan 29, 2026
6511dea
Double check the change
idseefeld Jan 29, 2026
12072a1
improve code health
idseefeld Jan 30, 2026
95388db
change new static classes into public static partial class NPocoSqlEx…
idseefeld Jan 30, 2026
c090be3
Merge branch 'main' into v173/21451-quote-raw-sql-names-with-SqlSynta…
idseefeld Jan 30, 2026
4d610a6
Merge branch 'main' into v173/21451-quote-raw-sql-names-with-SqlSynta…
idseefeld Jan 30, 2026
b6dfd5b
Merge branch 'v173/21451-quote-raw-sql-names-with-SqlSyntaxProvider-m…
idseefeld Jan 30, 2026
a88479f
resolve some Copilot review suggestions
idseefeld Jan 30, 2026
f140a57
revert Copilot suggestion because it decreases code health
idseefeld Jan 30, 2026
c9deac7
revert test
idseefeld Jan 30, 2026
3f1fed8
compare in with LOWER, change two methods from private to protected i…
idseefeld Jan 30, 2026
ca8fba2
revert Query.cs in this PR
idseefeld Jan 30, 2026
6ccbcc0
merge main into v173/21513-open-methods-for-plugins
idseefeld Feb 3, 2026
662c749
fix reverted changes
idseefeld Feb 3, 2026
eb102c3
restore change for this PR
idseefeld Feb 3, 2026
9694329
restore change for this PR
idseefeld Feb 3, 2026
cb617ce
Merge branch 'main' into v173/21513-open-methods-for-plugins
idseefeld Feb 3, 2026
8dd5973
Merge branch 'main' into v173/21513-open-methods-for-plugins
idseefeld Feb 3, 2026
2d05f06
Merge branch 'main' into v173/21513-open-methods-for-plugins
idseefeld Feb 4, 2026
2ea0e76
Merge branch 'main' into v173/21513-open-methods-for-plugins
idseefeld Feb 4, 2026
331f4e5
Merge branch 'main' into v173/21513-open-methods-for-plugins
idseefeld Feb 5, 2026
fa2bade
Merge branch 'main' into v173/21513-open-methods-for-plugins
idseefeld Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public UmbracoDatabaseFactory(

#endregion

private DbProviderFactory? DbProviderFactory
protected DbProviderFactory? DbProviderFactory
{
get
{
Expand Down Expand Up @@ -281,7 +281,7 @@ private InitializedPocoDataBuilder GetPocoDataFactoryResolver(Type type, IPocoDa
=> new UmbracoPocoDataBuilder(type, _pocoMappers, _upgrading).Init();

// method used by NPoco's UmbracoDatabaseFactory to actually create the database instance
private UmbracoDatabase? CreateDatabaseInstance()
protected virtual UmbracoDatabase? CreateDatabaseInstance()
{
if (ConnectionString is null || SqlContext is null || DbProviderFactory is null)
{
Expand Down
Loading