Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes break BEM convention #15

Open
certainlyakey opened this issue Apr 9, 2023 · 0 comments
Open

Classes break BEM convention #15

certainlyakey opened this issue Apr 9, 2023 · 0 comments

Comments

@certainlyakey
Copy link

It is mentioned in the README that internal CSS classes follow the BEM convention. However, in one aspect the convention is broken - some classes contain an element inside of an element, such as a "read more" class or "OK" class:

const cssClassNames = {
      root: 'cookie-consent',
      hide: 'cookie-consent__hide',
      buttons: {
        shared: 'cookie-consent__buttons-button',
        read_more: 'cookie-consent__buttons__read-more',
        ok: 'cookie-consent__buttons__close',
      },
};

According to BEM this should not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant