test long pointcount (previously int)

Author: unitycoder

Interfaces/IWriter.cs

@@ -6,7 +6,7 @@ public interface IWriter
     {
         // create output filestream, called before looping through points
         //bool InitWriter<TSettings>(TSettings importSettings, int pointCount);
-        bool InitWriter(dynamic importSettings, int pointCount, ILogger logger);
+        bool InitWriter(dynamic importSettings, long pointCount, ILogger logger);
         // optional: if need to create special file header
         void CreateHeader(int pointCount);
         // output point X,Y,Z values to file

MainWindow.xaml.cs

@@ -30,7 +30,7 @@ namespace PointCloudConverter
 {
     public partial class MainWindow : Window
     {
-        static readonly string version = "13.07.2025";
+        static readonly string version = "15.08.2025";
         static readonly string appname = "PointCloud Converter - " + version;
         static readonly string rootFolder = AppDomain.CurrentDomain.BaseDirectory;
 
@@ -291,7 +291,7 @@ private static async Task ProcessAllFiles(object workerParamsObject)
 
             if ((importSettings.useAutoOffset == true && importSettings.importMetadataOnly == false) || ((importSettings.importIntensity == true || importSettings.importClassification == true) && importSettings.importRGB == true && importSettings.packColors == true && importSettings.importMetadataOnly == false))
             {
-                int iterations = importSettings.offsetMode == "min" ? importSettings.maxFiles : 1; // 1 for legacy mode
+                int iterations = importSettings.offsetMode == "min" ? importSettings.maxFiles : 1; // 1 for legacy mode (first cloud only)
 
                 for (int i = 0, len = iterations; i < len; i++)
                 {
@@ -604,8 +604,8 @@ static void StartProgressTimer()
         public class ProgressInfo
         {
             public int Index { get; internal set; }        // Index of the ProgressBar in the UI
-            public int CurrentValue { get; internal set; } // Current progress value
-            public int MaxValue { get; internal set; }     // Maximum value for the progress
+            public long CurrentValue { get; internal set; } // Current progress value
+            public long MaxValue { get; internal set; }     // Maximum value for the progress
             public string FilePath { get; internal set; }
             public bool UseJsonLog { get; internal set; }
         }
@@ -675,8 +675,8 @@ static void ProgressTick(object sender, EventArgs e)
                     foreach (var progressInfo in progressInfos)
                     {
                         int index = progressInfo.Index;
-                        int currentValue = progressInfo.CurrentValue;
-                        int maxValue = progressInfo.MaxValue;
+                        long currentValue = progressInfo.CurrentValue;
+                        long maxValue = progressInfo.MaxValue;
 
                         // Access ProgressBar directly from the StackPanel.Children using its index
                         if (index >= 0 && index < mainWindowStatic.ProgressBarsContainer.Children.Count)
@@ -783,8 +783,8 @@ static bool ParseFile(ImportSettings importSettings, int fileIndex, int? taskId,
 
             if (importSettings.importMetadataOnly == false)
             {
-                int fullPointCount = taskReader.GetPointCount();
-                int pointCount = fullPointCount;
+                long fullPointCount = taskReader.GetPointCount();
+                long pointCount = fullPointCount;
 
                 // show stats for decimations
                 if (importSettings.skipPoints == true)
@@ -874,14 +874,14 @@ static bool ParseFile(ImportSettings importSettings, int fileIndex, int? taskId,
 
                 Log.Write(jsonString, LogEvent.File);
 
-                int checkCancelEvery = fullPointCount / 128;
+                long checkCancelEvery = fullPointCount / 128;
 
                 // detect is 0-255 or 0-65535 range
                 bool isCustomIntensityRange = false;
 
                 // Loop all points
                 // FIXME: would be nicer, if use different STEP value for skip, keep and limit..(to collect points all over the file, not just start)
-                int maxPointIterations = importSettings.useLimit ? pointCount : fullPointCount;
+                long maxPointIterations = importSettings.useLimit ? pointCount : fullPointCount;
                 for (int i = 0; i < maxPointIterations; i++)
                 {
                     // check for cancel every 1% of points

Readers/E57.cs

@@ -117,9 +117,9 @@ public Bounds GetBounds()
             };
         }
 
-        public int GetPointCount()
+        public long GetPointCount()
         {
-            return (int)(header?.E57Root?.Data3D?[0]?.Points?.RecordCount ?? 0);
+            return header?.E57Root?.Data3D?[0]?.Points?.RecordCount ?? 0;
         }
 
         public Float3 GetXYZ()

Readers/IReader.cs

@@ -8,7 +8,7 @@ public interface IReader
         // open filestream
         bool InitReader(ImportSettings importSettings, int fileIndex);
         // returns total point count, this is required to correctly read all points
-        int GetPointCount();
+        long GetPointCount();
         // bounds are used for AutoOffset
         Bounds GetBounds();
         // retrieve single point X,Y,Z coordinates (float)

Readers/LAZ.cs

@@ -347,7 +347,7 @@ Bounds IReader.GetBounds()
             return b;
         }
 
-        int IReader.GetPointCount()
+        long IReader.GetPointCount()
         {
             // get gps week offset from header
 
@@ -356,7 +356,7 @@ int IReader.GetPointCount()
             // check alternative point counts
             if (count == 0) count = (int)lazReader.header.extended_number_of_point_records;
             if (count == 0) count = lazReader.header.number_of_point_records;
-            return (int)count;
+            return count;
         }
 
         Color IReader.GetRGB()

Readers/PLY.cs

@@ -15,7 +15,7 @@ public class PLY : IReader, IDisposable
     {
         private PlyParser.Dataset dataset;
         private int pointIndex;
-        private int pointCount;
+        private long pointCount;
 
         private List<ElementData> vertexChunks;
         private int currentChunkIndex;
@@ -66,7 +66,7 @@ public bool InitReader(ImportSettings importSettings, int fileIndex)
 
         }
 
-        public int GetPointCount() => pointCount;
+        public long GetPointCount() => pointCount;
 
         public Bounds GetBounds() => bounds;
 

Tools/Tools.cs

@@ -422,7 +422,7 @@ public static void PrintHelpAndExit(char argSeparator, bool waitEnter = false)
             Console.WriteLine("-rgb" + argSeparator + "true or false\tReads RGB colors\tDefault is true");
             Console.WriteLine("-intensity" + argSeparator + "true or false\tReads Intensity as RGB color\tDefault is false");
             Console.WriteLine("-classification" + argSeparator + "false\t\tImport classification data\tDefault is false");
-            Console.WriteLine("-offset" + argSeparator + "true or false\tAuto-offsets cloud near 0,0,0 by using the first point as offset value\tDefault is true");
+            Console.WriteLine("-offset" + argSeparator + "true or false\tAuto-offsets cloud near 0,0,0\tDefault is true");
             Console.WriteLine("-gridsize" + argSeparator + "5\t\tGridsize in meters, splits cloud into tiles with this size. v3 only!\tDefault is 5, minimum is 0.1 (Note: values below 1 are not really tested)");
             Console.WriteLine("-minpoints" + argSeparator + "1000\t\tIf tile has less points than this value, its discarded. Good for removing straypoints. v3 only!\tDefault is 1000");
             Console.WriteLine("-scale" + argSeparator + "0.1\t\tScale XYZ values (You need meters inside Unity)\tDefault is off");
@@ -446,7 +446,7 @@ public static void PrintHelpAndExit(char argSeparator, bool waitEnter = false)
             Console.WriteLine("-checkoverlap" + argSeparator + "false\t\tCalculate overlapping tiles\tDefault is false");
             Console.WriteLine("-config" + argSeparator + "filename\t\tLoad arguments from text file (easier to handle separate settings for different projects)");
             Console.WriteLine("-usegrid" + argSeparator + "true\t\tSplits point cloud to grid (multiple files). Required for V3 format (automatically enabled if its off). \tDefault is true for v3");
-            Console.WriteLine("-offsetmode" + argSeparator + "min\t\tGet auto-offset bounds, min=min from all bounds, legacy= first cloud min bounds\tDefault is min");
+            Console.WriteLine("-offsetmode" + argSeparator + "min\t\tGet auto-offset bounds, min=min from all bounds, legacy=first cloud min bound\tDefault is min");
             Console.WriteLine("-srgb" + argSeparator + "false\t\tConvert raw sRGB values to Linear RGB\tDefault is false, enable this is your model seems too bright");
 
 

Writers/PCROOT.cs

@@ -157,7 +157,7 @@ public PCROOT(int? _taskID)
 
         static ILogger Log;
 
-        public bool InitWriter(dynamic _importSettings, int pointCount, ILogger logger)
+        public bool InitWriter(dynamic _importSettings, long pointCount, ILogger logger)
         {
             //Log.Write("--------------------- initwriter for taskID: " + taskID);
             var res = true;

Writers/UCPC.cs

@@ -46,12 +46,18 @@ public ImportSettings importSettings
 
         static ILogger Log;
 
-        bool IWriter.InitWriter(dynamic _importSettings, int _pointCount, ILogger logger)
+        bool IWriter.InitWriter(dynamic _importSettings, long _pointCount, ILogger logger)
         {
             importSettings = (ImportSettings)(object)_importSettings;
             Log = logger;
 
-            pointCount = _pointCount;
+            if (_pointCount > int.MaxValue)
+            {
+                Log.Write("Point count exceeds maximum value of int: " + _pointCount, LogEvent.Error);
+                return false;
+            }
+
+            pointCount = (int)_pointCount;
 
             pointsTempFile = importSettings.outputFile + "_PointsTemp";
             colorsTempFile = importSettings.outputFile + "_ColorsTemp";