Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): remove cached value when revalidation results in an error… #2611

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

cjpearson
Copy link
Contributor

… or invalid value

🔗 Linked issue

#1992

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When an SWR revalidation occurs the existing value is not initially deleted from the cache storage. Instead it only overwritten after the revalidation is complete. However, if the revalidation results in an error or invalid value, the original value remains in the cache storage. This can result in a stale value persisting in the cache throughout many revalidations, long after it should have been replaced.

Another approach could be to preemptively delete the stored value. This may simplify the implementation, but it means that other requests which arrive during the revalidation will not be served the cached value.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 added the cache label Sep 20, 2024
@pi0 pi0 self-requested a review as a code owner October 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants