Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan): route groups #2664

Merged
merged 13 commits into from
Sep 29, 2024
Merged

feat(scan): route groups #2664

merged 13 commits into from
Sep 29, 2024

Conversation

HigherOrderLogic
Copy link
Contributor

πŸ”— Linked issue

Resolves #1205.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allow user to group routes into separate folders withtout affecting the routes url.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@HigherOrderLogic
Copy link
Contributor Author

@pi0 can you help me with the test? Seems like the tests are only failing on some specific presets, not all.

@pi0 pi0 self-requested a review as a code owner September 29, 2024 21:13
@pi0 pi0 changed the title feat: route group feat(scan): route groups Sep 29, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The issue was some small regex issue.

@pi0 pi0 merged commit e3d6506 into nitrojs:v2 Sep 29, 2024
4 checks passed
@ghost ghost mentioned this pull request Oct 1, 2024
1 task
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support route groups
2 participants