Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter commonjs plugin when generating declaration #495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: filter commonjs plugin when generating declaration #495

wants to merge 2 commits into from

Conversation

kricsleo
Copy link
Contributor

resolves #396

The rollup-plugin-dts conflicts with @rollup/plugin-commonjs:

The plugin does its own import resolution through the typescript compiler, and usage together with other resolution plugins, such as node-resolve can lead to errors and is not recommended.
rollup-plugin-dts - what-to-expect

I'm not sure if it's okay to simply remove @rollup/plugin-commonjs when generating declarations. 🤔
I've tested some common cases, and it's working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

commonjs plugin should not include .ts extension
1 participant
@kricsleo