Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions should only run in unkey repo #2310

Open
3 tasks done
Flo4604 opened this issue Oct 10, 2024 · 4 comments
Open
3 tasks done

Actions should only run in unkey repo #2310

Flo4604 opened this issue Oct 10, 2024 · 4 comments
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey

Comments

@Flo4604
Copy link
Contributor

Flo4604 commented Oct 10, 2024

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Whenever I sync my fork with unkey all the actions are run

Steps to Reproduce

  1. Create unkey fork
  2. Sync it
  3. Workfllows will be run

Expected behavior

IMO the gh actions should only be run via either a force parameter or when in the unkey repo / not a fork.

Other information

No response

Screenshots

No response

Version info

irrelevant
@Flo4604 Flo4604 added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 10, 2024
Copy link

linear bot commented Oct 10, 2024

@chronark
Copy link
Collaborator

How do we fix this?

@Flo4604
Copy link
Contributor Author

Flo4604 commented Oct 11, 2024

How do we fix this?

Using the workflow if syntax should do it
if: github.repository == 'unkeyed/unkey' for example

@Flo4604
Copy link
Contributor Author

Flo4604 commented Oct 14, 2024

I wonder if it also would make sense to add ifs to the deploy changes if something in the code changed and not just something not relevant to the API or agent / dashboard etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey
Projects
None yet
Development

No branches or pull requests

2 participants