Plan for integrating Kiota extensions into Uno.Sdk

[kazo0]

Currently, the newly added Kiota HTTP Extensions library is not included in the Http UnoFeature.

The Problem

The Http UnoFeature currently pulls in the Uno.Extensions.Http.WinUI package AND the Uno.Extensions.Http.Refit package: https://github.com/unoplatform/uno/blob/7f303c19cfcbe8624887a3b92498157da09a569c/src/Uno.Sdk/targets/Uno.Extensions.Implicit.Packages.ProjectSystem.targets#L38-L41

It was proposed that Kiota would replace Refit and Refit would be no longer included with the Http UnoFeature. The problem with this is that any change to what the Http UnoFeature pulls in will be a breaking change.

Solutions

Including Both (non-breaking)

The only case that wouldn't be considered breaking would be for the Http UnoFeature to include both the Kiota and Refit extensions.

Split the Http UnoFeature (BREAKING)

Much like we do for Authentication and Logging, we have new dependant UnoFeatures that further customizes what is pulled in. For Authentication, we have the Authentication UnoFeature that pulls in the base Auth Extensions packages and then we have AuthenticationMsal and AuthenticationOidc which pull in the more specific Auth-based extensions. See: https://github.com/unoplatform/uno/blob/7f303c19cfcbe8624887a3b92498157da09a569c/src/Uno.Sdk/targets/Uno.Extensions.Implicit.Packages.ProjectSystem.targets#L11-L24

Same idea with Loggining and LoggingSerilog

It would make sense to follow this patterns and keep the Http UnoFeature but have it only pull in Uno.Extensions.Http.WinUI and then we could have HttpKiota and HttpRefit UnoFeatures.

Replace Refit with Kiota (BREAKING)

Last solution is what was originally proposed: remove Refit completely and just have the Http UnoFeature include Kiota instead.

[kazo0]

fyi @nickrandolph / @francoistanguay / @jeromelaban

[kazo0]

Follow up on that for release

We have docs as part of the Kiota work in the repo now: https://github.com/unoplatform/uno.extensions/blob/0d0e83a9166b0f0d475b232cd4af6633c532104a/doc/Learn/Http/HowTo-Kiota.md

What's left is to update the templates and the sdk to handle the choice between Refit and Kiota.

We will have something like we do for Authentication where we can decide what provider we want to use for Http. Similar to how it's done here: https://github.com/unoplatform/uno.templates/blob/b7a1e39b693a30b5c3ad7597416a3ebdbdb751cf/src/Uno.Templates/content/unoapp/.template.config/template.json#L576-L609

Where the options would be Refit and Kiota. I think there's value in keep Http as a "base" UnoFeature that would simply include the base package of https://www.nuget.org/packages/Uno.Extensions.Http.WinUI/. This is useful enough as is as it provide the registration of native http client handlers (

uno.extensions/src/Uno.Extensions.Http.UI/ServiceCollectionExtensions.cs

Line 31 in 6ecef0e

public static IServiceCollection AddNativeHandler(this IServiceCollection services, HostBuilderContext context)

) and the basic UseHttp Host Builder extensions (

uno.extensions/src/Uno.Extensions.Http.UI/HostBuilderExtensions.cs

Line 14 in 6ecef0e

public static IHostBuilder UseHttp(

)

This way, people using Http UnoFeature but not actually using any of the Refit bits wouldn't experience any issues. People relying on Refit would need to move to HttpRefit though.

Proposal

UnoFeature/SDK changes

• Create HttpRefit and HttpKiota UnoFeatures
• Remove the Refit dependencies from the Http UnoFeature

Wizard/Template changes

• Templates should change the --http flag to be a choice so you can use --http basic, --http kiota, and --http refit. Where basic would use the base Http feature, similar to what we have for logging:

[kazo0]

Relate issue tracking:

• [BREAKING][Kiota] Add HttpRefit and HttpKiota Uno SDK Features uno#20004
• https://github.com/unoplatform/private/issues/704
• https://github.com/unoplatform/private/issues/706
• [Kiota][Docs] Add small Kiota section to Http overview page #2736
• https://github.com/unoplatform/private/issues/710